refactor(codewhisperer): simplify isValidResponse() #4251

justinmk3 · web-flow · commit 3dba25e57f10 · 2024-01-10T01:58:29.000-08:00
This matches the logic at hasAtLeastOneValidSuggestion(). https://github.com/aws/aws-toolkit-vscode/blob/8e40b708235a4569aabca6209ecafdb4f909b498/src/codewhisperer/service/recommendationHandler.ts#L419-L421
diff --git a/src/codewhisperer/service/recommendationHandler.ts b/src/codewhisperer/service/recommendationHandler.ts
@@ -101,11 +101,7 @@ export class RecommendationHandler {
     }
 
     isValidResponse(): boolean {
-        return (
-            session.recommendations !== undefined &&
-            session.recommendations.length > 0 &&
-            session.recommendations.filter(option => option.content.length > 0).length > 0
-        )
+        return session.recommendations.some(r => r.content.trim() !== '')
     }
 
     async getServerResponse(

Original file line number	Diff line number	Diff line change
`@@ -101,11 +101,7 @@ export class RecommendationHandler {`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`isValidResponse(): boolean {`
`104`		`- return (`
`105`		`- session.recommendations !== undefined &&`
`106`		`- session.recommendations.length > 0 &&`
`107`		`- session.recommendations.filter(option => option.content.length > 0).length > 0`
`108`		`- )`
	`104`	`+ return session.recommendations.some(r => r.content.trim() !== '')`
`109`	`105`	`}`
`110`	`106`
`111`	`107`	`async getServerResponse(`