logging: supporess AWS SDK v2 warning #4445

Problem:
AWS JS SDK v2 shows a very noisy warning. This warning appears in local
debugging, in the CI logs, etc.

    NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.
    Please migrate your code to use AWS SDK for JavaScript (v3).
    For more information, check the migration guide at https://a.co/7PzMCcy
    (Use `Code Helper (Plugin) --trace-warnings ...` to show where the warning was created)

Solution:
Suppress the warning (see aws/aws-sdk-js#4354).
Updating to SDK v3 is in our backlog, so we don't need the warning.

Fix #4371

Author: justinmk3

packages/toolkit/src/extensionShared.ts

@@ -42,6 +42,9 @@ import { showQuickStartWebview } from './shared/extensionStartup'
 import { ExtContext } from './shared/extensions'
 import { getSamCliContext } from './shared/sam/cli/samCliContext'
 import { UriHandler } from './shared/vscode/uriHandler'
+import { disableAwsSdkWarning } from './shared/awsClientBuilder'
+
+disableAwsSdkWarning()
 
 let localize: nls.LocalizeFunc
 

packages/toolkit/src/shared/awsClientBuilder.ts

@@ -11,6 +11,12 @@ import { DevSettings } from './settings'
 import { getUserAgent } from './telemetry/util'
 import { telemetry } from './telemetry/telemetry'
 
+/** Suppresses a very noisy warning printed by AWS SDK v2, which clutters local debugging output, CI logs, etc. */
+export function disableAwsSdkWarning() {
+    // See https://github.com/aws/aws-sdk-js/issues/4354
+    require('aws-sdk/lib/maintenance_mode_message').suppress = true
+}
+
 // These are not on the public API but are very useful for logging purposes.
 // Tests guard against the possibility that these values change unexpectedly.
 // Since the field names are not prepended with `_` to signify visibility, the

packages/toolkit/src/test/globalSetup.test.ts

@@ -25,6 +25,9 @@ import * as testUtil from './testUtil'
 import { getTestWindow, resetTestWindow } from './shared/vscode/window'
 import { mapTestErrors, normalizeError, setRunnableTimeout } from './setupUtil'
 import { TelemetryDebounceInfo } from '../shared/vscode/commands2'
+import { disableAwsSdkWarning } from '../shared/awsClientBuilder'
+
+disableAwsSdkWarning()
 
 const testReportDir = join(__dirname, '../../../../../.test-reports') // Root project, not subproject
 const testLogOutput = join(testReportDir, 'testLog.log')