fix: disable existing profile check when adding profile

Problem:

When adding an auth profile, there is a possible race
condition where the global store (memento) is not
synchronized on a following read.

The scenario we were hitting was signing out of
a builder id, then signing in with a new one. It
would fail since the old builder id would still be
in the memento.

Soltion:

Do not check if the profile already exists,
just overwrite it.

Signed-off-by: Nikolas Komonen <[email protected]>

Author: nkomonen-amazon

src/credentials/auth.ts

@@ -199,10 +199,6 @@ export class ProfileStore {
     public async addProfile(id: string, profile: SsoProfile): Promise<StoredProfile<SsoProfile>>
     public async addProfile(id: string, profile: IamProfile): Promise<StoredProfile<IamProfile>>
     public async addProfile(id: string, profile: Profile): Promise<StoredProfile> {
-        if (this.getProfile(id) !== undefined) {
-            throw new Error(`Profile already exists: ${id}`)
-        }
-
         return this.putProfile(id, this.initMetadata(profile))
     }
 

src/test/credentials/auth.test.ts

@@ -134,9 +134,11 @@ describe('Auth', function () {
         assert.strictEqual(auth.activeConnection, undefined)
     })
 
-    it('throws when creating a duplicate connection', async function () {
-        await auth.createConnection(ssoProfile)
-        await assert.rejects(() => auth.createConnection(ssoProfile))
+    it('does not throw when creating a duplicate connection', async function () {
+        const initialConn = await auth.createConnection({ ...ssoProfile, scopes: ['a'] })
+        const duplicateConn = await auth.createConnection({ ...ssoProfile, scopes: ['b'] })
+        assert.deepStrictEqual(initialConn.scopes, ['a'])
+        assert.deepStrictEqual(duplicateConn.scopes, ['a', 'b'])
     })
 
     it('throws when using an invalid connection that was deleted', async function () {