feat(amazonq): auto-reject edit suggestions when cursor moves >25 lines away

Author: floralph

packages/amazonq/.changes/next-release/Feature-6c4c84d3-77b5-46b9-ac0e-7dc9dc9884af.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "auto-reject edit suggestions when cursor moves >25 lines away"
+}

packages/amazonq/src/app/inline/EditRendering/displayImage.ts

@@ -16,6 +16,8 @@ import { EditSuggestionState } from '../editSuggestionState'
 import type { AmazonQInlineCompletionItemProvider } from '../completion'
 import { vsCodeState } from 'aws-core-vscode/codewhisperer'
 
+const autoRejectEditCursorDistance = 25
+
 export class EditDecorationManager {
     private imageDecorationType: vscode.TextEditorDecorationType
     private removedCodeDecorationType: vscode.TextEditorDecorationType
@@ -346,6 +348,19 @@ export async function displaySvgDecoration(
             void vscode.commands.executeCommand('aws.amazonq.inline.rejectEdit')
         }
     })
+    const cursorChangeListener = vscode.window.onDidChangeTextEditorSelection((e) => {
+        if (!EditSuggestionState.isEditSuggestionActive()) {
+            return
+        }
+        if (e.textEditor !== editor) {
+            return
+        }
+        const currentPosition = e.selections[0].active
+        const distance = Math.abs(currentPosition.line - startLine)
+        if (distance > autoRejectEditCursorDistance) {
+            void vscode.commands.executeCommand('aws.amazonq.inline.rejectEdit')
+        }
+    })
     await decorationManager.displayEditSuggestion(
         editor,
         svgImage,
@@ -371,6 +386,7 @@ export async function displaySvgDecoration(
 
             await decorationManager.clearDecorations(editor)
             documentChangeListener.dispose()
+            cursorChangeListener.dispose()
             const params: LogInlineCompletionSessionResultsParams = {
                 sessionId: session.sessionId,
                 completionSessionResult: {
@@ -405,6 +421,7 @@ export async function displaySvgDecoration(
             getLogger().info('Edit suggestion rejected')
             await decorationManager.clearDecorations(editor)
             documentChangeListener.dispose()
+            cursorChangeListener.dispose()
             const params: LogInlineCompletionSessionResultsParams = {
                 sessionId: session.sessionId,
                 completionSessionResult: {

packages/amazonq/test/unit/app/inline/EditRendering/displayImage.test.ts

@@ -6,7 +6,8 @@
 import * as vscode from 'vscode'
 import * as sinon from 'sinon'
 import assert from 'assert'
-import { EditDecorationManager } from '../../../../../src/app/inline/EditRendering/displayImage'
+import { EditDecorationManager, displaySvgDecoration } from '../../../../../src/app/inline/EditRendering/displayImage'
+import { EditSuggestionState } from '../../../../../src/app/inline/editSuggestionState'
 
 describe('EditDecorationManager', function () {
     let sandbox: sinon.SinonSandbox
@@ -174,3 +175,222 @@ describe('EditDecorationManager', function () {
         sinon.assert.calledWith(editorStub.setDecorations.secondCall, manager['removedCodeDecorationType'], [])
     })
 })
+
+describe('displaySvgDecoration cursor distance auto-reject', function () {
+    let sandbox: sinon.SinonSandbox
+    let editorStub: sinon.SinonStubbedInstance<vscode.TextEditor>
+    let documentStub: sinon.SinonStubbedInstance<vscode.TextDocument>
+    let windowStub: sinon.SinonStub
+    let commandsStub: sinon.SinonStub
+    let editSuggestionStateStub: sinon.SinonStub
+    let onDidChangeTextEditorSelectionStub: sinon.SinonStub
+    let selectionChangeListener: (e: vscode.TextEditorSelectionChangeEvent) => void
+
+    beforeEach(function () {
+        sandbox = sinon.createSandbox()
+
+        documentStub = {
+            getText: sandbox.stub().returns('Original code content'),
+            uri: vscode.Uri.file('/test/file.ts'),
+            lineAt: sandbox.stub().returns({
+                text: 'Line text content',
+                range: new vscode.Range(0, 0, 0, 18),
+                rangeIncludingLineBreak: new vscode.Range(0, 0, 0, 19),
+                firstNonWhitespaceCharacterIndex: 0,
+                isEmptyOrWhitespace: false,
+            }),
+        } as unknown as sinon.SinonStubbedInstance<vscode.TextDocument>
+
+        editorStub = {
+            document: documentStub,
+            setDecorations: sandbox.stub(),
+        } as unknown as sinon.SinonStubbedInstance<vscode.TextEditor>
+
+        // Mock vscode.window.onDidChangeTextEditorSelection
+        onDidChangeTextEditorSelectionStub = sandbox.stub()
+        onDidChangeTextEditorSelectionStub.returns({ dispose: sandbox.stub() })
+        windowStub = sandbox.stub(vscode.window, 'onDidChangeTextEditorSelection')
+        windowStub.callsFake((callback) => {
+            selectionChangeListener = callback
+            return { dispose: sandbox.stub() }
+        })
+
+        // Mock vscode.commands.executeCommand
+        commandsStub = sandbox.stub(vscode.commands, 'executeCommand')
+
+        // Mock EditSuggestionState
+        editSuggestionStateStub = sandbox.stub(EditSuggestionState, 'isEditSuggestionActive')
+        editSuggestionStateStub.returns(true)
+
+        // Mock other required dependencies
+        sandbox.stub(vscode.workspace, 'onDidChangeTextDocument').returns({ dispose: sandbox.stub() })
+    })
+
+    afterEach(function () {
+        sandbox.restore()
+    })
+
+    it('should not reject when cursor moves less than 25 lines away', async function () {
+        const startLine = 50
+        await displaySvgDecoration(
+            editorStub as unknown as vscode.TextEditor,
+            vscode.Uri.parse('data:image/svg+xml;base64,test'),
+            startLine,
+            'new code',
+            [],
+            {} as any,
+            {} as any,
+            { itemId: 'test', insertText: 'patch' } as any
+        )
+
+        // Simulate cursor moving 24 lines away (should not reject)
+        const position = new vscode.Position(startLine + 24, 0)
+        const selection = new vscode.Selection(position, position)
+        const selectionChangeEvent = {
+            textEditor: editorStub,
+            selections: [selection],
+            kind: vscode.TextEditorSelectionChangeKind.Mouse,
+        } as vscode.TextEditorSelectionChangeEvent
+
+        selectionChangeListener(selectionChangeEvent)
+
+        sinon.assert.notCalled(commandsStub)
+    })
+
+    it('should not reject when cursor moves exactly 25 lines away', async function () {
+        const startLine = 50
+        await displaySvgDecoration(
+            editorStub as unknown as vscode.TextEditor,
+            vscode.Uri.parse('data:image/svg+xml;base64,test'),
+            startLine,
+            'new code',
+            [],
+            {} as any,
+            {} as any,
+            { itemId: 'test', insertText: 'patch' } as any
+        )
+
+        // Simulate cursor moving exactly 25 lines away (should not reject)
+        const position = new vscode.Position(startLine + 25, 0)
+        const selection = new vscode.Selection(position, position)
+        const selectionChangeEvent = {
+            textEditor: editorStub,
+            selections: [selection],
+            kind: vscode.TextEditorSelectionChangeKind.Mouse,
+        } as vscode.TextEditorSelectionChangeEvent
+
+        selectionChangeListener(selectionChangeEvent)
+
+        sinon.assert.notCalled(commandsStub)
+    })
+
+    it('should reject when cursor moves more than 25 lines away', async function () {
+        const startLine = 50
+        await displaySvgDecoration(
+            editorStub as unknown as vscode.TextEditor,
+            vscode.Uri.parse('data:image/svg+xml;base64,test'),
+            startLine,
+            'new code',
+            [],
+            {} as any,
+            {} as any,
+            { itemId: 'test', insertText: 'patch' } as any
+        )
+
+        // Simulate cursor moving 26 lines away (should reject)
+        const position = new vscode.Position(startLine + 26, 0)
+        const selection = new vscode.Selection(position, position)
+        const selectionChangeEvent = {
+            textEditor: editorStub,
+            selections: [selection],
+            kind: vscode.TextEditorSelectionChangeKind.Mouse,
+        } as vscode.TextEditorSelectionChangeEvent
+
+        selectionChangeListener(selectionChangeEvent)
+
+        sinon.assert.calledOnceWithExactly(commandsStub, 'aws.amazonq.inline.rejectEdit')
+    })
+
+    it('should reject when cursor moves more than 25 lines before the edit', async function () {
+        const startLine = 50
+        await displaySvgDecoration(
+            editorStub as unknown as vscode.TextEditor,
+            vscode.Uri.parse('data:image/svg+xml;base64,test'),
+            startLine,
+            'new code',
+            [],
+            {} as any,
+            {} as any,
+            { itemId: 'test', insertText: 'patch' } as any
+        )
+
+        // Simulate cursor moving 26 lines before the edit (should reject)
+        const position = new vscode.Position(startLine - 26, 0)
+        const selection = new vscode.Selection(position, position)
+        const selectionChangeEvent = {
+            textEditor: editorStub,
+            selections: [selection],
+            kind: vscode.TextEditorSelectionChangeKind.Mouse,
+        } as vscode.TextEditorSelectionChangeEvent
+
+        selectionChangeListener(selectionChangeEvent)
+
+        sinon.assert.calledOnceWithExactly(commandsStub, 'aws.amazonq.inline.rejectEdit')
+    })
+
+    it('should not reject when edit is near beginning of file and cursor cannot move far enough', async function () {
+        const startLine = 10 // Edit near beginning of file
+        await displaySvgDecoration(
+            editorStub as unknown as vscode.TextEditor,
+            vscode.Uri.parse('data:image/svg+xml;base64,test'),
+            startLine,
+            'new code',
+            [],
+            {} as any,
+            {} as any,
+            { itemId: 'test', insertText: 'patch' } as any
+        )
+
+        // Simulate cursor at line 0 (can't go further back)
+        const position = new vscode.Position(0, 0)
+        const selection = new vscode.Selection(position, position)
+        const selectionChangeEvent = {
+            textEditor: editorStub,
+            selections: [selection],
+            kind: vscode.TextEditorSelectionChangeKind.Mouse,
+        } as vscode.TextEditorSelectionChangeEvent
+
+        selectionChangeListener(selectionChangeEvent)
+
+        sinon.assert.notCalled(commandsStub)
+    })
+
+    it('should not reject when edit suggestion is not active', async function () {
+        editSuggestionStateStub.returns(false)
+
+        const startLine = 50
+        await displaySvgDecoration(
+            editorStub as unknown as vscode.TextEditor,
+            vscode.Uri.parse('data:image/svg+xml;base64,test'),
+            startLine,
+            'new code',
+            [],
+            {} as any,
+            {} as any,
+            { itemId: 'test', insertText: 'patch' } as any
+        )
+
+        // Simulate cursor moving far away
+        const position = new vscode.Position(startLine + 100, 0)
+        const selection = new vscode.Selection(position, position)
+        const selectionChangeEvent = {
+            textEditor: editorStub,
+            selections: [selection],
+            kind: vscode.TextEditorSelectionChangeKind.Mouse,
+        } as vscode.TextEditorSelectionChangeEvent
+
+        selectionChangeListener(selectionChangeEvent)
+
+        sinon.assert.notCalled(commandsStub)
+    })
+})