Skip to content

Commit 525e675

Browse files
Merge master into feature/ui-e2e-tests
2 parents b88816a + d1959b9 commit 525e675

File tree

3 files changed

+21
-13
lines changed

3 files changed

+21
-13
lines changed

packages/amazonq/src/app/inline/EditRendering/displayImage.ts

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -324,19 +324,20 @@ export async function displaySvgDecoration(
324324
isInlineEdit: true,
325325
}
326326
languageClient.sendNotification('aws/logInlineCompletionSessionResults', params)
327-
// Only auto trigger on acceptance if there is a nextToken
328-
if (inlineCompletionProvider && session.editsStreakPartialResultToken) {
329-
await inlineCompletionProvider.provideInlineCompletionItems(
330-
editor.document,
331-
endPosition,
332-
{
333-
triggerKind: vscode.InlineCompletionTriggerKind.Automatic,
334-
selectedCompletionInfo: undefined,
335-
},
336-
new vscode.CancellationTokenSource().token,
337-
{ emitTelemetry: false, showUi: false, editsStreakToken: session.editsStreakPartialResultToken }
338-
)
339-
}
327+
session.triggerOnAcceptance = true
328+
// VS Code triggers suggestion on every keystroke, temporarily disable trigger on acceptance
329+
// if (inlineCompletionProvider && session.editsStreakPartialResultToken) {
330+
// await inlineCompletionProvider.provideInlineCompletionItems(
331+
// editor.document,
332+
// endPosition,
333+
// {
334+
// triggerKind: vscode.InlineCompletionTriggerKind.Automatic,
335+
// selectedCompletionInfo: undefined,
336+
// },
337+
// new vscode.CancellationTokenSource().token,
338+
// { emitTelemetry: false, showUi: false, editsStreakToken: session.editsStreakPartialResultToken }
339+
// )
340+
// }
340341
},
341342
async () => {
342343
// Handle reject

packages/amazonq/src/app/inline/completion.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,12 @@ export class AmazonQInlineCompletionItemProvider implements InlineCompletionItem
272272
const prevSessionId = prevSession?.sessionId
273273
const prevItemId = this.sessionManager.getActiveRecommendation()?.[0]?.itemId
274274
const prevStartPosition = prevSession?.startPosition
275+
if (prevSession?.triggerOnAcceptance) {
276+
getAllRecommendationsOptions = {
277+
...getAllRecommendationsOptions,
278+
editsStreakToken: prevSession?.editsStreakPartialResultToken,
279+
}
280+
}
275281
const editor = window.activeTextEditor
276282
if (prevSession && prevSessionId && prevItemId && prevStartPosition) {
277283
const prefix = document.getText(new Range(prevStartPosition, position))

packages/amazonq/src/app/inline/sessionManager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export interface CodeWhispererSession {
1818
diagnosticsBeforeAccept: FileDiagnostic | undefined
1919
// partialResultToken for the next trigger if user accepts an EDITS suggestion
2020
editsStreakPartialResultToken?: number | string
21+
triggerOnAcceptance?: boolean
2122
}
2223

2324
export class SessionManager {

0 commit comments

Comments
 (0)