change logic to use explicit file names and extensions

Author: Hamed Soleimani

packages/amazonq/.changes/next-release/Bug Fix-993929aa-5dd5-440a-9150-8ae5ba5f56ac.json

@@ -1,4 +1,4 @@
 {
 	"type": "Bug Fix",
-	"description": "Include mvn and gradle files in repo archives"
+	"description": "Amazon Q can update mvn and gradle build files"
 }

packages/core/src/shared/filetypes.ts

@@ -173,6 +173,7 @@ export const codefileExtensions = new Set([
     '.cljs',
     '.cls',
     '.cmake',
+    '.cmd',
     '.cob',
     '.cobra',
     '.coffee',
@@ -274,6 +275,7 @@ export const codefileExtensions = new Set([
     '.pp',
     '.pro',
     '.prolog',
+    '.properties',
     '.ps1',
     '.psd1',
     '.psm1',
@@ -351,21 +353,10 @@ export const codefileExtensions = new Set([
 ])
 
 // Code file names without an extension
-export const codefileNames = new Set(['Dockerfile', 'Dockerfile.build'])
-
-// To match gradlew, .mvn/*, etc
-export const wellKnownSubnames = new Set(['gradle', 'mvn'])
+export const codefileNames = new Set(['Dockerfile', 'Dockerfile.build', 'gradlew', 'mvnw'])
 
 /** Returns true if `filename` is a code file. */
 export function isCodeFile(filename: string): boolean {
     const ext = path.extname(filename).toLowerCase()
-    if (codefileExtensions.has(ext) || codefileNames.has(path.basename(filename))) {
-        return true
-    }
-    for (const subname of wellKnownSubnames) {
-        if (filename.includes(subname)) {
-            return true
-        }
-    }
-    return false
+    return codefileExtensions.has(ext) || codefileNames.has(path.basename(filename))
 }

packages/core/src/test/shared/filetypes.test.ts

@@ -13,6 +13,7 @@ import * as workspaceUtils from '../../shared/utilities/workspaceUtils'
 import { toArrayAsync } from '../../shared/utilities/collectionUtils'
 import { waitUntil } from '../../shared/utilities/timeoutUtils'
 import { mapMetadata } from '../../shared/telemetry/telemetryLogger'
+import { isCodeFile } from '../../shared/filetypes'
 
 async function getMetrics(n: number, metricName: string, timeout = 1000) {
     return await waitUntil(
@@ -148,3 +149,23 @@ describe('file_editAwsFile telemetry', function () {
         // assert.strictEqual(r?.length, 1, 'emitted file_editAwsFile too many times')
     })
 })
+
+describe('isCodeFile', () => {
+    it('returns true for code files', function () {
+        const codeFiles = [
+            'test.py',
+            'test.js',
+            'Dockerfile',
+            'gradlew',
+            'mvnw',
+            'build.gradle',
+            'gradle/wrapper/gradle-wrapper.properties',
+        ]
+        codeFiles.forEach((codeFilePath) => assert.strictEqual(isCodeFile(codeFilePath), true))
+    })
+
+    it('returns false for other files', function () {
+        const codeFiles = ['compiled.exe', 'random_file']
+        codeFiles.forEach((filePath) => assert.strictEqual(isCodeFile(filePath), false))
+    })
+})