fix(childprocess): log rejected command

justinmk3 · justinmk3 · commit 5c56251be98e · 2025-04-07T08:50:45.000-07:00
Problem:
Unhandled promise rejection results in mysterious CI log message:

    rejected promise not handled within 1 second:
    Error: Command exited with non-zero code: 1

Solution:
Include the command name+args in the rejection message.
diff --git a/packages/core/src/shared/utilities/processUtils.ts b/packages/core/src/shared/utilities/processUtils.ts
@@ -367,7 +367,7 @@ export class ChildProcess {
                     if (typeof rejectOnErrorCode === 'function') {
                         reject(rejectOnErrorCode(code))
                     } else {
-                        reject(new Error(`Command exited with non-zero code: ${code}`))
+                        reject(new Error(`Command exited with non-zero code (${code}): ${this.toString()}`))
                     }
                 }
                 if (options.waitForStreams === false) {

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ export class ChildProcess {`
`367`	`367`	`if (typeof rejectOnErrorCode === 'function') {`
`368`	`368`	`reject(rejectOnErrorCode(code))`
`369`	`369`	`} else {`
`370`		- reject(new Error(`Command exited with non-zero code: ${code}`))
	`370`	+ reject(new Error(`Command exited with non-zero code (${code}): ${this.toString()}`))
`371`	`371`	`}`
`372`	`372`	`}`
`373`	`373`	`if (options.waitForStreams === false) {`