Skip to content

Commit 5e2bc19

Browse files
Apply suggestions from code review
Co-authored-by: Roger Zhang <[email protected]>
1 parent cd38b32 commit 5e2bc19

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/core/src/test/shared/sam/utils.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,15 +253,15 @@ describe('SAM utils', async function () {
253253
assert.strictEqual(result, value1)
254254
})
255255

256-
it('4. updateRecentResponse should return the update only specified key', async () => {
256+
it('4. updateRecentResponse should only update the specified key', async () => {
257257
await updateRecentResponse(mementoRootKey, identifier, key2, value2)
258258
const result1 = getRecentResponse(mementoRootKey, identifier, key1)
259259
const result2 = getRecentResponse(mementoRootKey, identifier, key2)
260260
assert.strictEqual(result1, value1)
261261
assert.strictEqual(result2, value2)
262262
})
263263

264-
it('5. updateRecentResponse should log when failure to update value', async () => {
264+
it('5. updateRecentResponse should log when failed to update value', async () => {
265265
sinon.stub(globals.context.workspaceState, 'update').rejects(new Error('Error updating value'))
266266
try {
267267
await updateRecentResponse(mementoRootKey, identifier, key2, value2)

packages/core/src/test/shared/ui/sam/templatePrompter.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe('createTemplatePrompter', () => {
3636

3737
it('should create quick pick items from registry items', () => {
3838
// Arrange
39-
const recentTemplatePathStub = sinon.stub().returns(undefined)
39+
const recentTemplatePathStub = sandbox.stub().returns(undefined)
4040
sandbox.replace(SamUtilsModule, 'getRecentResponse', recentTemplatePathStub)
4141
const workspaceFolder = vscode.workspace.workspaceFolders?.[0]
4242
assert.ok(workspaceFolder)

0 commit comments

Comments
 (0)