Skip to content

Commit 6074374

Browse files
authored
fix(codewhisperer): patch #5621 and remove language not yet supported (#5630)
## Problem disable inlineCompletion support for language `Dart`, `SystemVerilog`, `Lua`, `Swift`, `Vue`, `Powershell`, `R` which were added by #5621 and we disable it because service is not ready yet thus will causing 4xx error `improper formed request`. ## Solution Disable Dart, SystemVerilog, Lua, Swift, Vue, Powershell, R
1 parent ab7cec4 commit 6074374

File tree

3 files changed

+31
-9
lines changed

3 files changed

+31
-9
lines changed

packages/amazonq/test/unit/codewhisperer/tracker/codewhispererCodeCoverageTracker.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ describe('codewhispererCodecoverageTracker', function () {
3030
it('unsupported language', function () {
3131
assert.strictEqual(CodeWhispererCodeCoverageTracker.getTracker('vb'), undefined)
3232
assert.strictEqual(CodeWhispererCodeCoverageTracker.getTracker('ipynb'), undefined)
33+
assert.strictEqual(CodeWhispererCodeCoverageTracker.getTracker('r'), undefined)
34+
assert.strictEqual(CodeWhispererCodeCoverageTracker.getTracker('dart'), undefined)
35+
assert.strictEqual(CodeWhispererCodeCoverageTracker.getTracker('swift'), undefined)
36+
assert.strictEqual(CodeWhispererCodeCoverageTracker.getTracker('lua'), undefined)
37+
assert.strictEqual(CodeWhispererCodeCoverageTracker.getTracker('powershell'), undefined)
3338
})
3439

3540
it('supported language', function () {
@@ -40,7 +45,6 @@ describe('codewhispererCodecoverageTracker', function () {
4045
assert.notStrictEqual(CodeWhispererCodeCoverageTracker.getTracker('cpp'), undefined)
4146
assert.notStrictEqual(CodeWhispererCodeCoverageTracker.getTracker('ruby'), undefined)
4247
assert.notStrictEqual(CodeWhispererCodeCoverageTracker.getTracker('go'), undefined)
43-
assert.notStrictEqual(CodeWhispererCodeCoverageTracker.getTracker('r'), undefined)
4448
})
4549

4650
it('supported language and should return singleton object per language', function () {

packages/amazonq/test/unit/codewhisperer/util/runtimeLanguageContext.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@ describe('runtimeLanguageContext', function () {
3636
['json', true],
3737
['yaml', true],
3838
['tf', true],
39-
['dart', true],
40-
['lua', true],
41-
['powershell', true],
42-
['r', true],
43-
['swift', true],
44-
['systemVerilog', true],
45-
['vue', true],
39+
['dart', false],
40+
['lua', false],
41+
['powershell', false],
42+
['r', false],
43+
['swift', false],
44+
['systemVerilog', false],
45+
['vue', false],
4646
['plaintext', false],
4747
['html', false],
4848
['vb', false],

packages/core/src/codewhisperer/util/runtimeLanguageContext.ts

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,25 @@ export class RuntimeLanguageContext {
235235
*/
236236
public isLanguageSupported(languageId: string): boolean {
237237
const lang = this.normalizeLanguage(languageId)
238-
return lang !== undefined && this.normalizeLanguage(languageId) !== 'plaintext'
238+
switch (lang) {
239+
case undefined:
240+
return false
241+
242+
case 'plaintext':
243+
return false
244+
245+
case 'dart':
246+
case 'lua':
247+
case 'powershell':
248+
case 'r':
249+
case 'swift':
250+
case 'vue':
251+
case 'systemVerilog':
252+
return false
253+
254+
default:
255+
return true
256+
}
239257
}
240258
/**
241259
*

0 commit comments

Comments
 (0)