telemetry: rename vscode_viewLogs => toolkit_viewLogs #2934

justinmk3 · web-flow · commit 6186ad216ed6 · 2022-10-18T09:21:34.000-07:00
There is now a common metric for this: aws/aws-toolkit-common#377
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -3232,7 +3232,7 @@
         "report": "nyc report --reporter=html --reporter=json"
     },
     "devDependencies": {
-        "@aws-toolkits/telemetry": "^1.0.72",
+        "@aws-toolkits/telemetry": "^1.0.76",
         "@cspotcode/source-map-support": "^0.8.1",
         "@sinonjs/fake-timers": "^8.1.0",
         "@types/adm-zip": "^0.4.34",
diff --git a/src/shared/logger/commands.ts b/src/shared/logger/commands.ts
@@ -31,7 +31,7 @@ export class Logging {
     public constructor(private readonly defaultLogUri: vscode.Uri, private readonly logger: Logger) {}
 
     public async openLogUri(logUri = this.defaultLogUri): Promise<vscode.TextEditor | undefined> {
-        telemetry.vscode_viewLogs.emit() // Perhaps add additional argument to know which log was viewed?
+        telemetry.toolkit_viewLogs.emit() // Perhaps add additional argument to know which log was viewed?
 
         return vscode.window.showTextDocument(logUri)
     }
diff --git a/src/shared/telemetry/vscodeTelemetry.json b/src/shared/telemetry/vscodeTelemetry.json
@@ -171,10 +171,6 @@
             "unit": "Count",
             "passive": true
         },
-        {
-            "name": "vscode_viewLogs",
-            "description": "View the VSCode IDE logs"
-        },
         {
             "name": "aws_showExplorerErrorDetails",
             "description": "Called when getting more details about errors thrown by the explorer",

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export class Logging {`
`31`	`31`	`public constructor(private readonly defaultLogUri: vscode.Uri, private readonly logger: Logger) {}`
`32`	`32`
`33`	`33`	`public async openLogUri(logUri = this.defaultLogUri): Promise<vscode.TextEditor \| undefined> {`
`34`		`- telemetry.vscode_viewLogs.emit() // Perhaps add additional argument to know which log was viewed?`
	`34`	`+ telemetry.toolkit_viewLogs.emit() // Perhaps add additional argument to know which log was viewed?`
`35`	`35`
`36`	`36`	`return vscode.window.showTextDocument(logUri)`
`37`	`37`	`}`