Merge staging into feature/lambda-get-started

aws-toolkit-automation · web-flow · commit 61bcdf2280da · 2024-10-23T20:09:51.000+02:00
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -41,7 +41,7 @@ jobs:
         runs-on: ubuntu-latest
         strategy:
             matrix:
-                node-version: [16.x]
+                node-version: [18.x]
                 vscode-version: [stable]
         env:
             NODE_OPTIONS: '--max-old-space-size=8192'
@@ -62,7 +62,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                node-version: [16.x]
+                node-version: [18.x]
                 vscode-version: [minimum, stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
@@ -110,7 +110,7 @@ jobs:
         strategy:
             fail-fast: true
             matrix:
-                node-version: [16.x]
+                node-version: [18.x]
                 vscode-version: [stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
@@ -136,7 +136,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                node-version: [16.x]
+                node-version: [18.x]
                 vscode-version: [stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
diff --git a/buildspec/linuxIntegrationTests.yml b/buildspec/linuxIntegrationTests.yml
@@ -21,7 +21,7 @@ phases:
     install:
         run-as: root
         runtime-versions:
-            nodejs: 16
+            nodejs: 18
             dotnet: 6.0
             java: latest
 
diff --git a/buildspec/linuxTests.yml b/buildspec/linuxTests.yml
@@ -18,7 +18,7 @@ phases:
     install:
         run-as: root
         runtime-versions:
-            nodejs: 16
+            nodejs: 18
         commands:
             - bash buildspec/shared/linux-install.sh
 
diff --git a/buildspec/packageTestVsix.yml b/buildspec/packageTestVsix.yml
@@ -13,7 +13,7 @@ phases:
     install:
         run-as: root
         runtime-versions:
-            nodejs: 16
+            nodejs: 18
         commands:
             - bash buildspec/shared/linux-install.sh
 
diff --git a/buildspec/windowsTests.yml b/buildspec/windowsTests.yml
@@ -5,7 +5,7 @@ env:
 phases:
     install:
         runtime-versions:
-            nodejs: 16
+            nodejs: 18
         commands:
             - |
                 if(-Not($Env:CODECOV_TOKEN -eq $null)) {
diff --git a/packages/core/scripts/test/launchTestUtilities.ts b/packages/core/scripts/test/launchTestUtilities.ts
@@ -182,13 +182,16 @@ async function invokeVSCodeCli(vsCodeExecutablePath: string, args: string[]): Pr
     }
 
     console.log(`Invoking vscode CLI command:\n    "${cli}" ${JSON.stringify(cmdArgs)}`)
+    // Shell option must be true on windows to avoid security error: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
     const spawnResult = proc.spawnSync(cli, cmdArgs, {
         encoding: 'utf-8',
         stdio: 'pipe',
+        shell: process.platform === 'win32',
     })
 
     if (spawnResult.status !== 0) {
         console.log('output: %s', spawnResult.output)
+        console.log('error: %O', spawnResult.error)
         throw new Error(`VS Code CLI command failed (exit-code: ${spawnResult.status}): ${cli} ${cmdArgs}`)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -182,13 +182,16 @@ async function invokeVSCodeCli(vsCodeExecutablePath: string, args: string[]): Pr`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	console.log(`Invoking vscode CLI command:\n "${cli}" ${JSON.stringify(cmdArgs)}`)
	`185`	`+ // Shell option must be true on windows to avoid security error: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2`
`185`	`186`	`const spawnResult = proc.spawnSync(cli, cmdArgs, {`
`186`	`187`	`encoding: 'utf-8',`
`187`	`188`	`stdio: 'pipe',`
	`189`	`+ shell: process.platform === 'win32',`
`188`	`190`	`})`
`189`	`191`
`190`	`192`	`if (spawnResult.status !== 0) {`
`191`	`193`	`console.log('output: %s', spawnResult.output)`
	`194`	`+ console.log('error: %O', spawnResult.error)`
`192`	`195`	throw new Error(`VS Code CLI command failed (exit-code: ${spawnResult.status}): ${cli} ${cmdArgs}`)
`193`	`196`	`}`
`194`	`197`