fix: Toolkit always opens Output panel on startup #3939

Problem:
Output panel always opens at VS Code launch. #3930

Solution:
Instead of showing Output panel at Redshift activation, change to show Output panel only when a message is added.

Author: yi-jin-0

.changes/next-release/Bug Fix-fff4dbbd-2664-43c3-bf6f-98cf1440ace2.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "Output panel always opens at VS Code launch."
+}

src/redshift/activation.ts

@@ -21,7 +21,6 @@ import { showViewLogsMessage } from '../shared/utilities/messages'
 
 export async function activate(ctx: ExtContext): Promise<void> {
     const outputChannel = globals.outputChannel
-    outputChannel.show(true)
 
     if ('NotebookEdit' in vscode) {
         ctx.extensionContext.subscriptions.push(
@@ -86,6 +85,7 @@ function getNotebookConnectClickedHandler(
             return
         }
         redshiftNotebookController.redshiftClient = new DefaultRedshiftClient(connectionParams.region!.id)
+        outputChannel.show(true)
         try {
             const redshiftClient = (redshiftNotebookController.redshiftClient = new DefaultRedshiftClient(
                 connectionParams.region!.id
@@ -134,6 +134,7 @@ function getEditConnectionHandler(outputChannel: vscode.OutputChannel) {
                 await vscode.commands.executeCommand('aws.refreshAwsExplorerNode', redshiftWarehouseNode)
             }
         } catch (error) {
+            outputChannel.show(true)
             outputChannel.appendLine(
                 `Redshift: Failed to fetch databases for warehouse ${redshiftWarehouseNode.name} - ${
                     (error as Error).message

src/redshift/explorer/redshiftWarehouseNode.ts

@@ -145,6 +145,7 @@ export class RedshiftWarehouseNode extends AWSTreeNodeBase implements AWSResourc
                     await updateConnectionParamsState(this.arn, this.connectionParams)
                     return childNodes
                 } catch (error) {
+                    globals.outputChannel.show(true)
                     const msg = `Redshift: Failed to fetch databases for warehouse ${this.redshiftWarehouse.name} - ${
                         (error as Error).message
                     }`