fix(amazonq): /review shows zero results

Problem:
`/review` followed by `Review active file`, always gets zero results
from the server.

Solution:
Roll back the profile-related changes to securityscan-related code.
It's unclear why this fixes the issue. This is only a mitigation.

Author: justinmk3

packages/core/src/codewhisperer/commands/startSecurityScan.ts

@@ -108,7 +108,6 @@ export async function startSecurityScan(
     zipUtil: ZipUtil = new ZipUtil(),
     scanUuid?: string
 ) {
-    const profile = AuthUtil.instance.regionProfileManager.activeRegionProfile
     const logger = getLoggerForScope(scope)
     /**
      * Step 0: Initial Code Scan telemetry
@@ -188,7 +187,7 @@ export async function startSecurityScan(
         const uploadStartTime = performance.now()
         const scanName = randomUUID()
         try {
-            artifactMap = await getPresignedUrlAndUpload(client, zipMetadata, scope, scanName, profile)
+            artifactMap = await getPresignedUrlAndUpload(client, zipMetadata, scope, scanName)
         } finally {
             await zipUtil.removeTmpFiles(zipMetadata, scope)
             codeScanTelemetryEntry.artifactsUploadDuration = performance.now() - uploadStartTime
@@ -213,8 +212,7 @@ export async function startSecurityScan(
             artifactMap,
             codeScanTelemetryEntry.codewhispererLanguage,
             scope,
-            scanName,
-            profile
+            scanName
         )
         if (scanJob.status === 'Failed') {
             logger.verbose(`${scanJob.errorMessage}`)
@@ -237,8 +235,7 @@ export async function startSecurityScan(
                 scanUuid,
             })
         }
-        // pass profile
-        const jobStatus = await pollScanJobStatus(client, scanJob.jobId, scope, codeScanStartTime, profile)
+        const jobStatus = await pollScanJobStatus(client, scanJob.jobId, scope, codeScanStartTime)
         if (jobStatus === 'Failed') {
             logger.verbose(`Security scan failed.`)
             throw new CodeScanJobFailedError()
@@ -264,8 +261,7 @@ export async function startSecurityScan(
             CodeWhispererConstants.codeScanFindingsSchema,
             projectPaths,
             scope,
-            editor,
-            profile
+            editor
         )
         for (const issue of securityRecommendationCollection
             .flatMap(({ issues }) => issues)

packages/core/src/codewhisperer/service/securityScanHandler.ts

@@ -13,7 +13,6 @@ import {
     codeScanState,
     CodeScanStoppedError,
     onDemandFileScanState,
-    RegionProfile,
 } from '../models/model'
 import { sleep } from '../../shared/utilities/timeoutUtils'
 import * as codewhispererClient from '../client/codewhisperer'
@@ -51,18 +50,13 @@ export async function listScanResults(
     codeScanFindingsSchema: string,
     projectPaths: string[],
     scope: CodeWhispererConstants.CodeAnalysisScope,
-    editor: vscode.TextEditor | undefined,
-    profile?: RegionProfile
+    editor: vscode.TextEditor | undefined
 ) {
     const logger = getLoggerForScope(scope)
     const codeScanIssueMap: Map<string, RawCodeScanIssue[]> = new Map()
     const aggregatedCodeScanIssueList: AggregatedCodeScanIssue[] = []
     const requester = (request: codewhispererClient.ListCodeScanFindingsRequest) => client.listCodeScanFindings(request)
-    const request: codewhispererClient.ListCodeScanFindingsRequest = {
-        jobId,
-        codeAnalysisFindingsSchema: codeScanFindingsSchema,
-        profileArn: profile?.arn,
-    }
+    const request: codewhispererClient.ListCodeScanFindingsRequest = { jobId, codeScanFindingsSchema }
     const collection = pageableToCollection(requester, request, 'nextToken')
     const issues = await collection
         .flatten()
@@ -209,8 +203,7 @@ export async function pollScanJobStatus(
     client: DefaultCodeWhispererClient,
     jobId: string,
     scope: CodeWhispererConstants.CodeAnalysisScope,
-    codeScanStartTime: number,
-    profile?: RegionProfile
+    codeScanStartTime: number
 ) {
     const pollingStartTime = performance.now()
     // We don't expect to get results immediately, so sleep for some time initially to not make unnecessary calls
@@ -223,7 +216,6 @@ export async function pollScanJobStatus(
         throwIfCancelled(scope, codeScanStartTime)
         const req: codewhispererClient.GetCodeScanRequest = {
             jobId: jobId,
-            profileArn: profile?.arn,
         }
         const resp = await client.getCodeScan(req)
         logger.verbose(`GetCodeScanRequest requestId: ${resp.$response.requestId}`)
@@ -250,8 +242,7 @@ export async function createScanJob(
     artifactMap: codewhispererClient.ArtifactMap,
     languageId: string,
     scope: CodeWhispererConstants.CodeAnalysisScope,
-    scanName: string,
-    profile?: RegionProfile
+    scanName: string
 ) {
     const logger = getLoggerForScope(scope)
     logger.verbose(`Creating scan job...`)
@@ -263,7 +254,6 @@ export async function createScanJob(
         },
         scope: codeAnalysisScope,
         codeScanName: scanName,
-        profileArn: profile?.arn,
     }
     const resp = await client.createCodeScan(req).catch((err) => {
         getLogger().error(`Failed creating scan job. Request id: ${err.requestId}`)
@@ -286,8 +276,7 @@ export async function getPresignedUrlAndUpload(
     client: DefaultCodeWhispererClient,
     zipMetadata: ZipMetadata,
     scope: CodeWhispererConstants.CodeAnalysisScope,
-    scanName: string,
-    profile?: RegionProfile
+    scanName: string
 ) {
     const artifactMap = await telemetry.amazonq_createUpload.run(async (span) => {
         const logger = getLoggerForScope(scope)
@@ -310,7 +299,6 @@ export async function getPresignedUrlAndUpload(
                     codeScanName: scanName,
                 },
             },
-            profileArn: profile?.arn,
         }
         logger.verbose(`Prepare for uploading src context...`)
         const srcResp = await client.createUploadUrl(srcReq).catch((err) => {