Merge branch 'master' into loggingNestedObj

Author: Hweinstock

packages/amazonq/.changes/next-release/Feature-93485fee-05c0-4dc9-abde-9072590cbd45.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "Enable default `@workspace` context of Amazon Q chat for certain users"
+}

packages/core/src/codewhisperer/util/editorContext.ts

@@ -130,9 +130,11 @@ export async function buildGenerateRecommendationRequest(editor: vscode.TextEdit
     const fileContext = extractContextForCodeWhisperer(editor)
 
     const tokenSource = new vscode.CancellationTokenSource()
+    // the supplement context fetch mechanisms each has a timeout of supplementalContextTimeoutInMs
+    // adding 10 ms for overall timeout as buffer
     setTimeout(() => {
         tokenSource.cancel()
-    }, supplementalContextTimeoutInMs)
+    }, supplementalContextTimeoutInMs + 10)
     const supplementalContexts = await fetchSupplementalContext(editor, tokenSource.token)
 
     logSupplementalContext(supplementalContexts)

packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts

@@ -71,13 +71,13 @@ export async function fetchSupplementalContextForSrc(
         async function () {
             return await fetchSupplementalContextForSrcV1(editor, cancellationToken)
         },
-        { timeout: supplementalContextTimeoutInMs, interval: 10, truthy: false }
+        { timeout: supplementalContextTimeoutInMs, interval: 5, truthy: false }
     )
     const promiseV2 = waitUntil(
         async function () {
             return await fetchSupplementalContextForSrcV2(editor)
         },
-        { timeout: supplementalContextTimeoutInMs, interval: 10, truthy: false }
+        { timeout: supplementalContextTimeoutInMs, interval: 5, truthy: false }
     )
     const [resultV1, resultV2] = await Promise.all([promiseV1, promiseV2])
     return resultV2 ?? resultV1

packages/core/src/codewhispererChat/controllers/chat/controller.ts

@@ -47,11 +47,11 @@ import { randomUUID } from '../../../shared/crypto'
 import { LspController } from '../../../amazonq/lsp/lspController'
 import { CodeWhispererSettings } from '../../../codewhisperer/util/codewhispererSettings'
 import { getSelectedCustomization } from '../../../codewhisperer/util/customizationUtil'
-import { FeatureConfigProvider } from '../../../shared/featureConfig'
 import { getHttpStatusCode, AwsClientResponseError } from '../../../shared/errors'
 import { uiEventRecorder } from '../../../amazonq/util/eventRecorder'
-import { globals } from '../../../shared'
+import { globals, waitUntil } from '../../../shared'
 import { telemetry } from '../../../shared/telemetry'
+import { Auth } from '../../../auth'
 import { isSsoConnection } from '../../../auth/connection'
 import { inspect } from '../../../shared/utilities/collectionUtils'
 
@@ -636,17 +636,23 @@ export class ChatController {
                     return
                 }
             }
-            // if user does not have @workspace in the prompt, but user is in the data collection group
-            // If the user is in the data collection group but turned off local index to opt-out, do not collect data.
-            // TODO: Remove this entire block of code in one month as requested
+            // if user does not have @workspace in the prompt, but user is Amazon internal
+            // add project context by default
             else if (
-                FeatureConfigProvider.instance.isAmznDataCollectionGroup() &&
+                Auth.instance.isInternalAmazonUser() &&
                 !LspController.instance.isIndexingInProgress() &&
                 CodeWhispererSettings.instance.isLocalIndexEnabled()
             ) {
-                getLogger().info(`amazonq: User is in data collection group`)
                 const start = performance.now()
-                triggerPayload.relevantTextDocuments = await LspController.instance.query(triggerPayload.message)
+                triggerPayload.relevantTextDocuments = await waitUntil(
+                    async function () {
+                        if (triggerPayload.message) {
+                            return await LspController.instance.query(triggerPayload.message)
+                        }
+                        return []
+                    },
+                    { timeout: 500, interval: 200, truthy: false }
+                )
                 triggerPayload.projectContextQueryLatencyMs = performance.now() - start
             }
         }

packages/core/src/shared/featureConfig.ts

@@ -18,6 +18,7 @@ import globals from './extensionGlobals'
 import { getClientId, getOperatingSystem } from './telemetry/util'
 import { extensionVersion } from './vscode/env'
 import { telemetry } from './telemetry'
+import { Auth } from '../auth'
 
 export class FeatureContext {
     constructor(
@@ -51,8 +52,6 @@ export class FeatureConfigProvider {
 
     static #instance: FeatureConfigProvider
 
-    private _isDataCollectionGroup = false
-
     constructor() {
         this.fetchFeatureConfigs().catch((e) => {
             getLogger().error('fetchFeatureConfigs failed: %s', (e as Error).message)
@@ -65,10 +64,6 @@ export class FeatureConfigProvider {
         return (this.#instance ??= new this())
     }
 
-    isAmznDataCollectionGroup(): boolean {
-        return this._isDataCollectionGroup
-    }
-
     isNewProjectContextGroup(): boolean {
         return this.featureConfigs.get(Features.projectContextFeature)?.variation === 'TREATMENT'
     }
@@ -145,11 +140,8 @@ export class FeatureConfigProvider {
                     }
                 }
             }
-
-            const dataCollectionValue = this.featureConfigs.get(Features.dataCollectionFeature)?.value.stringValue
-            if (dataCollectionValue === 'data-collection') {
-                this._isDataCollectionGroup = true
-                // Enable local workspace index by default, for Amzn users.
+            if (Auth.instance.isInternalAmazonUser()) {
+                // Enable local workspace index by default only once, for Amzn users.
                 const isSet = globals.globalState.get<boolean>('aws.amazonq.workspaceIndexToggleOn') || false
                 if (!isSet) {
                     await CodeWhispererSettings.instance.enableLocalIndex()