ci: fail on "rejected promise not handled"

Problem:
Unhandled "rejected promises" are silently ignored when running tests in CI.

Solution:
Enable CI failure for `run_and_report`.

Author: justinmk3

buildspec/linuxTests.yml

@@ -36,7 +36,7 @@ phases:
                     # Ensure that "foo | run_and_report" fails correctly.
                     set -o pipefail
                     . buildspec/shared/common.sh
-                    2>&1 xvfb-run npm test --silent | run_and_report \
+                    2>&1 xvfb-run npm test --silent | run_and_report 2 \
                         'rejected promise not handled' \
                         'This typically indicates a bug. Read https://developer.mozilla.org/docs/Web/JavaScript/Guide/Using_promises#error_handling'
                 }

buildspec/shared/common.sh

@@ -1,32 +1,48 @@
+#!/bin/env bash
+
 # Common functions used by other CI scripts.
 # "Include" this file by sourcing (not executing) it:
 #     . buildspec/shared/common.sh
 
+# Ignore these patterns when deciding if the build should fail.
+#   - "waiting for browser": from `ssoAccessTokenProvider.test.ts`, unclear how to fix it.
+#   - "Webview is disposed": only happens on vscode "minimum" (1.68.0)
+#   - "HTTPError: Response code …": caused by github rate-limiting.
+_ignore_pat='Timed-out waiting for browser login flow\|HTTPError: Response code 403\|HTTPError: Response code 404'
+if [ "$VSCODE_TEST_VERSION" = 'minimum' ]; then
+    _ignore_pat="$_ignore_pat"'\|Webview is disposed'
+fi
+
 # Expects stdin + two args:
-#   1: grep pattern
-#   2: message shown at end of report, if pattern was found in stdin.
+#   1: error code to return on failure
+#   2: grep pattern
+#   3: message shown at end of report, if pattern was found in stdin.
 # Usage:
-#   echo foo | run_and_report '.*' 'You must fix this. See https://example.com'
+#   echo foo | run_and_report 1 '.*' 'You must fix this. See https://example.com'
 run_and_report() {
     set -o pipefail
-    local pat="${1}"
-    local msg="${2}"
+    local errcode="${1}"
+    local pat="${2}"
+    local msg="${3}"
     local r=0
     mkfifo testout
     (cat testout &)
     # Capture messages that we may want to fail (or report) later.
     tee testout \
         | { grep > testout-err --line-buffered -E "$pat" || true; }
+
     echo ''
-    if grep "$pat" testout-err | sort; then
-        printf '\nERROR: Found %s "%s" in test output (see above).\n%s\n\n' \
-            "$(grep "${pat}" testout-err | wc -l | tr -d ' ')" \
+
+    if grep -v "${_ignore_pat}" testout-err | grep "$pat" | sort; then
+        printf '\nERROR: Test output matched this pattern %s times:\n       "%s"\n%s\n\n' \
+            "$(grep -c "${pat}" testout-err)" \
             "$pat" \
             "       ${msg}"
-        # TODO: fail the CI job
-        # r=1
-        r=0
+        r=${errcode}
+    else
+        printf '\nOK: Not found in test output: "%s"\n' "$pat"
     fi
+
     rm -f testout testout-err
     return "$r"
 }

buildspec/shared/linux-pre_build.sh

@@ -22,4 +22,5 @@ if [ "$TOOLKITS_CODEARTIFACT_DOMAIN" ] && [ "$TOOLKITS_CODEARTIFACT_REPO" ] && [
 fi
 
 # TODO: move this to the "install" phase?
-npm 2>&1 ci | run_and_report 'npm WARN deprecated' 'Deprecated dependencies must be updated.'
+# TODO: fail in CI
+npm 2>&1 ci | run_and_report 0 'npm WARN deprecated' 'Deprecated dependencies must be updated.'