fix(auth): help button in "save connection" prompt does nothing (#3046)

JadenSimon · web-flow · commit 6a8ad2f44ee1 · 2022-12-12T09:33:05.000-08:00
diff --git a/.changes/next-release/Bug Fix-1c8e7c12-027a-47d4-a6ed-30fdf16c0cb7.json b/.changes/next-release/Bug Fix-1c8e7c12-027a-47d4-a6ed-30fdf16c0cb7.json
@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "Help button on the \"save connection\" prompt does nothing"
+}
diff --git a/src/credentials/secondaryAuth.ts b/src/credentials/secondaryAuth.ts
@@ -31,7 +31,7 @@ async function promptUseNewConnection(newConn: Connection, oldConn: Connection,
     } as const
 
     const helpButton = createHelpButton()
-    const openLink = () => helpButton.onClick()
+    const openLink = helpButton.onClick.bind(helpButton)
     helpButton.onClick = () => {
         telemetry.ui_click.emit({ elementId: 'connection_multiple_auths_help' })
         openLink()

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +	"type": "Bug Fix",
 +	"description": "Help button on the \"save connection\" prompt does nothing"
 +}