test: avoid duplicate test data

Author: Hweinstock

packages/core/src/test/awsService/ec2/prompter.test.ts

@@ -12,6 +12,7 @@ import { Ec2InstanceNode } from '../../../awsService/ec2/explorer/ec2InstanceNod
 import { testClient, testInstance, testParentNode } from './explorer/ec2ParentNode.test'
 import { intoCollection } from '../../../shared/utilities/collectionUtils'
 import { AsyncCollection } from '../../../shared/utilities/asyncCollection'
+import { DataQuickPickItem } from '../../../shared/ui/pickerPrompter'
 
 describe('Ec2Prompter', async function () {
     it('initializes properly', function () {
@@ -83,6 +84,24 @@ describe('Ec2Prompter', async function () {
                 },
             ],
         ]
+
+        const defaultQuickPickItems: DataQuickPickItem<string>[] = [
+            {
+                label: Ec2Prompter.getLabel(defaultInstances[0][0]),
+                detail: defaultInstances[0][0].InstanceId,
+                data: defaultInstances[0][0].InstanceId,
+            },
+            {
+                label: Ec2Prompter.getLabel(defaultInstances[0][1]),
+                detail: defaultInstances[0][1].InstanceId,
+                data: defaultInstances[0][1].InstanceId,
+            },
+            {
+                label: Ec2Prompter.getLabel(defaultInstances[1][0]),
+                detail: defaultInstances[1][0].InstanceId,
+                data: defaultInstances[1][0].InstanceId,
+            },
+        ]
         const defaultGetInstances: (regionCode: string) => AsyncCollection<PatchedEc2Instance[]> = (_) =>
             intoCollection(defaultInstances)
 
@@ -98,23 +117,7 @@ describe('Ec2Prompter', async function () {
 
             const itemsIterator = prompter.getInstancesAsQuickPickItems('test-region')
             const items = await extractItems(itemsIterator)
-            assert.deepStrictEqual(items, [
-                {
-                    label: Ec2Prompter.getLabel(defaultInstances[0][0]),
-                    detail: defaultInstances[0][0].InstanceId,
-                    data: defaultInstances[0][0].InstanceId,
-                },
-                {
-                    label: Ec2Prompter.getLabel(defaultInstances[0][1]),
-                    detail: defaultInstances[0][1].InstanceId,
-                    data: defaultInstances[0][1].InstanceId,
-                },
-                {
-                    label: Ec2Prompter.getLabel(defaultInstances[1][0]),
-                    detail: defaultInstances[1][0].InstanceId,
-                    data: defaultInstances[1][0].InstanceId,
-                },
-            ])
+            assert.deepStrictEqual(items, defaultQuickPickItems)
         })
 
         it('applies filter when given', async function () {
@@ -126,18 +129,7 @@ describe('Ec2Prompter', async function () {
             const itemsIterator = prompter.getInstancesAsQuickPickItems('test-region')
             const items = await extractItems(itemsIterator)
 
-            assert.deepStrictEqual(items, [
-                {
-                    label: Ec2Prompter.getLabel(defaultInstances[0][0]),
-                    detail: defaultInstances[0][0].InstanceId,
-                    data: defaultInstances[0][0].InstanceId,
-                },
-                {
-                    label: Ec2Prompter.getLabel(defaultInstances[1][0]),
-                    detail: defaultInstances[1][0].InstanceId,
-                    data: defaultInstances[1][0].InstanceId,
-                },
-            ])
+            assert.deepStrictEqual(items, [defaultQuickPickItems[0], defaultQuickPickItems[2]])
         })
     })