telemetry: missing result field in featureDev metrics #4519

Problem:
- A couple events were missing result: 'Succeeded'

Solution:
- Add it

Author: jpinkney-aws

packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts

@@ -159,11 +159,13 @@ export class FeatureDevController {
                     telemetry.amazonq_codeGenerationThumbsUp.emit({
                         amazonqConversationId: session?.conversationId,
                         value: 1,
+                        result: 'Succeeded',
                     })
                 } else if (vote === 'downvote') {
                     telemetry.amazonq_codeGenerationThumbsDown.emit({
                         amazonqConversationId: session?.conversationId,
                         value: 1,
+                        result: 'Succeeded',
                     })
                 }
                 break

packages/core/src/amazonqFeatureDev/session/session.ts

@@ -116,7 +116,11 @@ export class Session {
         )
         this._latestMessage = ''
 
-        telemetry.amazonq_isApproachAccepted.emit({ amazonqConversationId: this.conversationId, enabled: true })
+        telemetry.amazonq_isApproachAccepted.emit({
+            amazonqConversationId: this.conversationId,
+            enabled: true,
+            result: 'Succeeded',
+        })
     }
 
     async send(msg: string): Promise<Interaction> {