Schemas: fix code generation on download failure (#1484)

When downloading code bindings for custom schemas (all schemas other than
aws.schemas registry) fails with an error, the code generation logic tries to
download code bindings (this automatically works for aws.schemas as they are
pre-generated), if it fails with NotFound exception then we generate the code
bindings.

Problem: We used stack parameter from the Error interface to determine the
error type, which seems to be not returned anymore.

Solution: Use new parameter `name` which contains the error type.

Author: ejafarli

.changes/next-release/Bug Fix-55703bad-99e5-4cd8-ba13-8f913f7c044d.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "Schemas: download failure would not trigger code generation under certain conditions"
+}

src/eventSchemas/commands/downloadSchemaItemCode.ts

@@ -136,7 +136,7 @@ export class SchemaCodeDownloader {
             zipContents = await this.downloader.download(request)
         } catch (err) {
             const error = err as Error
-            if (error.stack && error.stack.includes('NotFoundException')) {
+            if (error.name == 'ResourceNotFound') {
                 //If the code generation wasn't previously kicked off, do so
                 vscode.window.showInformationMessage(
                     localize(

src/test/eventSchemas/commands/downloadSchemaItemCode.test.ts

@@ -387,7 +387,7 @@ describe('SchemaCodeDownload', () => {
             assert.strictEqual(response, fileContent, `${expectedFilePath} :file content do not match`)
         })
 
-        it('should return error if downloading code fails with anything other than NotFoundException', async () => {
+        it('should return error if downloading code fails with anything other than ResourceNotFound', async () => {
             const customError = new Error('Custom error')
             const codeDownloaderStub = sandbox.stub(downloader, 'download').returns(Promise.reject(customError))
 
@@ -399,7 +399,7 @@ describe('SchemaCodeDownload', () => {
             assert.strictEqual(customError, error, 'Should throw Custom error')
         })
 
-        it('should generate code if download fails with NotFoundException and place it into requested directory', async () => {
+        it('should generate code if download fails with ResourceNotFound and place it into requested directory', async () => {
             sandbox.stub(poller, 'pollForCompletion').returns(Promise.resolve('CREATE_COMPLETE'))
             const codeDownloaderStub = sandbox.stub(downloader, 'download')
             const codeGeneratorResponse: Schemas.PutCodeBindingResponse = {
@@ -408,7 +408,7 @@ describe('SchemaCodeDownload', () => {
             sandbox.stub(generator, 'generate').returns(Promise.resolve(codeGeneratorResponse))
 
             const customError = new Error('Resource Not Found Exception')
-            customError.stack = 'This should trigger the code in catch block - NotFoundException'
+            customError.name = 'ResourceNotFound'
 
             codeDownloaderStub.onCall(0).returns(Promise.reject(customError)) // should fail on first call
             codeDownloaderStub.onCall(1).returns(Promise.resolve(arrayBuffer)) // should succeed on second