Skip to content

Commit 6e0c84c

Browse files
committed
fixup
1 parent 70afbcf commit 6e0c84c

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -427,16 +427,16 @@ Example:
427427
}
428428
```
429429

430-
<a name="amazonqLsp-settings">Overrides specifically for the language server can be set using the `aws.dev.amazonqLsp` setting. This is a JSON object consisting of keys/values required to override language server: `manifestUrl`, 'supportedVersions', 'id', and 'locationOverride'.</a>
430+
<a name="amazonqLsp-settings">Overrides specifically for the Amazon Q language server can be set using the `aws.dev.amazonqLsp` setting. This is a JSON object consisting of keys/values required to override language server: `manifestUrl`, `supportedVersions`, `id`, and `locationOverride`.</a>
431431

432432
Example:
433433

434434
```json
435435
"aws.dev.amazonqLsp": {
436436
"manifestUrl": "https://custom.url/manifest.json",
437437
"supportedVersions": "4.0.0",
438-
"id": "AmazonQSetting",
439-
"locationOverride": "/custom/path",
438+
"id": "AmazonQ",
439+
"locationOverride": "/custom/path/to/local/lsp/folder",
440440
}
441441
```
442442

packages/amazonq/.vscode/launch.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"env": {
1515
"SSMDOCUMENT_LANGUAGESERVER_PORT": "6010",
1616
"WEBPACK_DEVELOPER_SERVER": "http://localhost:8080"
17-
// "AWS_LANGUAGE_SERVER_OVERRIDE": "${workspaceFolder}/../../../language-servers/app/aws-lsp-codewhisperer-runtimes/out/token-standalone.js",
17+
// "__AMAZONQLSP_LOCATION_OVERRIDE": "${workspaceFolder}/../../../language-servers/app/aws-lsp-codewhisperer-runtimes/out/token-standalone.js",
1818
},
1919
"envFile": "${workspaceFolder}/.local.env",
2020
"outFiles": ["${workspaceFolder}/dist/**/*.js", "${workspaceFolder}/../core/dist/**/*.js"],

packages/amazonq/test/unit/amazonq/lsp/config.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ describe('getAmazonQLspConfig', () => {
2222
sandbox = sinon.createSandbox()
2323

2424
serviceConfigStub = sandbox.stub()
25-
26-
// Create the DevSettings mock with the properly typed stub
2725
sandbox.stub(DevSettings, 'instance').get(() => ({
2826
getServiceConfig: serviceConfigStub,
2927
}))
@@ -33,7 +31,7 @@ describe('getAmazonQLspConfig', () => {
3331
sandbox.restore()
3432
})
3533

36-
it('uses default config when no overrides are present', () => {
34+
it('uses default config', () => {
3735
serviceConfigStub.returns({})
3836
const config = getAmazonQLspConfig()
3937
assert.deepStrictEqual(config, defaultAmazonQLspConfig)
@@ -50,7 +48,7 @@ describe('getAmazonQLspConfig', () => {
5048
})
5149
})
5250

53-
it('override default settings', () => {
51+
it('overrides default settings', () => {
5452
serviceConfigStub.returns(settingConfig)
5553

5654
const config = getAmazonQLspConfig()

0 commit comments

Comments
 (0)