chore: remove package.json syncing between subprojects

- Min vscode and TS versions are now gathered from currently running extension package.json instead of hardcoded core/package.json.

Author: hayemaxi

package-lock.json

@@ -109,7 +109,6 @@
             // Since `webpack --watch` never terminates (but finishes packaging at some point),
             // VS Code uses this to parse the CLI output to pattern match something that indicates it is done
             "problemMatcher": "$ts-webpack-watch",
-            "dependsOn": ["copyPackageJson"],
             "options": {
                 "cwd": "${workspaceFolder}/../../packages/core"
             }
@@ -123,8 +122,7 @@
         {
             "label": "webRunTerminate",
             "command": "echo ${input:webRunTerminate}",
-            "type": "shell",
-            "dependsOn": ["restorePackageJson"]
+            "type": "shell"
         },
         // ---------- End: Web Mode Tasks ----------
         {

packages/amazonq/.vscode/tasks.json

@@ -46,10 +46,9 @@
     "browser": "./dist/src/extensionWeb",
     "scripts": {
         "vscode:prepublish": "npm run clean && npm run buildScripts && webpack --mode production",
-        "buildScripts": "npm run generateNonCodeFiles && npm run copyFiles && npm run generateIcons && npm run generateSettings && npm run syncPackageJson && tsc -p ./ --noEmit",
+        "buildScripts": "npm run generateNonCodeFiles && npm run copyFiles && npm run generateIcons && npm run generateSettings && tsc -p ./ --noEmit",
         "generateNonCodeFiles": "ts-node ../../scripts/generateNonCodeFiles.ts",
         "copyFiles": "ts-node ./scripts/build/copyFiles.ts",
-        "syncPackageJson": "ts-node ./scripts/build/syncPackageJson.ts",
         "clean": "ts-node ../../scripts/clean.ts dist/ LICENSE NOTICE",
         "compile": "npm run clean && npm run buildScripts && webpack --mode development",
         "compileOnly": "tsc -p ./",

packages/amazonq/package.json

@@ -5,11 +5,10 @@
 
 import * as semver from 'semver'
 import * as vscode from 'vscode'
-import * as packageJson from '../../../package.json'
 import { getLogger } from '../logger'
 import { onceChanged } from '../utilities/functionUtils'
 import { ChildProcess } from '../utilities/childProcess'
-import { isWeb } from '../extensionGlobals'
+import globals, { isWeb } from '../extensionGlobals'
 
 /**
  * Returns true if the current build is running on CI (build server).
@@ -68,15 +67,15 @@ export function isMinVscode(throwWhen?: string): boolean {
 /**
  * Returns the minimum vscode "engine" version declared in `package.json`.
  */
-export function getMinVscodeVersion(): string {
-    return packageJson.engines.vscode.replace(/[^~]/, '')
+export function getMinVscodeVersion(pkgJson?: { [key: string]: any }): string {
+    return (pkgJson ?? globals.context.extension.packageJSON).engines.vscode.replace(/[^~]/, '')
 }
 
 /**
  * Returns the minimum nodejs version declared in `package.json`.
  */
-export function getMinNodejsVersion(): string {
-    return packageJson.devDependencies['@types/node'].replace(/[^~]/, '')
+export function getMinNodejsVersion(pkgJson?: { [key: string]: any }): string {
+    return (pkgJson ?? globals.context.extension.packageJSON).devDependencies['@types/node'].replace(/[^~]/, '')
 }
 
 export function getCodeCatalystDevEnvId(): string | undefined {

packages/amazonq/scripts/build/syncPackageJson.ts

@@ -66,7 +66,15 @@ export class FakeExtensionContext implements vscode.ExtensionContext {
         extensionUri: vscode.Uri.file('/fake/extension/dir/'),
         id: 'aws.toolkit.fake.extension',
         isActive: true,
-        packageJSON: {},
+        packageJSON: {
+            // Required for shared/vscode/env.ts, which may be referenced by any codepath.
+            engines: {
+                vscode: '^1.68.0',
+            },
+            devDependencies: {
+                '@types/node': '^16.18.95',
+            },
+        },
     }
 
     /**

packages/core/src/shared/vscode/env.ts

@@ -6,6 +6,7 @@
 import assert from 'assert'
 import * as semver from 'semver'
 import * as env from '../shared/vscode/env'
+import packageJson from '../../package.json'
 
 // Checks project config and dependencies, to remind us to remove old things
 // when possible.
@@ -17,7 +18,7 @@ describe('tech debt', function () {
     }
 
     it('vscode minimum version', async function () {
-        const minVscode = env.getMinVscodeVersion()
+        const minVscode = env.getMinVscodeVersion(packageJson)
 
         assert.ok(
             semver.lt(minVscode, '1.75.0'),
@@ -31,7 +32,7 @@ describe('tech debt', function () {
     })
 
     it('nodejs minimum version', async function () {
-        const minNodejs = env.getMinNodejsVersion()
+        const minNodejs = env.getMinNodejsVersion(packageJson)
 
         // XXX: available since node 16, but not sure how much work this will be, yet.
         assert.ok(

packages/core/src/test/fakeExtensionContext.ts

@@ -7,7 +7,7 @@
             "label": "extensionInit",
             "type": "shell",
             "command": "echo 'extensionInit'",
-            "dependsOn": ["copyPackageJson", "watch"],
+            "dependsOn": ["watch"],
             "presentation": {
                 "close": true
             }
@@ -55,41 +55,13 @@
                 "cwd": "${workspaceFolder}/../../packages/core"
             }
         },
-        {
-            "label": "copyPackageJson",
-            "type": "shell",
-            "command": "npm run copyPackageJson -- --development",
-            "isBackground": false,
-            "group": {
-                "kind": "build",
-                "isDefault": true
-            },
-            "presentation": {
-                "close": true
-            }
-        },
-        {
-            "label": "restorePackageJson",
-            "type": "npm",
-            "script": "restorePackageJson",
-            "problemMatcher": [],
-            "isBackground": false,
-            "group": {
-                "kind": "build",
-                "isDefault": true
-            },
-            "presentation": {
-                "close": true
-            }
-        },
         {
             "label": "extensionTerminate",
             "command": "echo run terminate",
             "type": "shell",
             "presentation": {
                 "close": true
-            },
-            "dependsOn": ["restorePackageJson"]
+            }
         },
         // ---------- Start: Web Mode Tasks ----------
         {
@@ -146,7 +118,6 @@
             // Since `webpack --watch` never terminates (but finishes packaging at some point),
             // VS Code uses this to parse the CLI output to pattern match something that indicates it is done
             "problemMatcher": "$ts-webpack-watch",
-            "dependsOn": ["copyPackageJson"],
             "options": {
                 "cwd": "${workspaceFolder}/../../packages/core"
             }
@@ -160,8 +131,7 @@
         {
             "label": "webRunTerminate",
             "command": "echo ${input:webRunTerminate}",
-            "type": "shell",
-            "dependsOn": ["restorePackageJson"]
+            "type": "shell"
         },
         // ---------- End: Web Mode Tasks ----------
         {
@@ -177,7 +147,7 @@
         {
             "type": "npm",
             "script": "compile",
-            "dependsOn": ["Kill Tasks", "copyPackageJson"],
+            "dependsOn": ["Kill Tasks"],
             "problemMatcher": "$tsc"
         },
         {