fix: user agent defaults to true

Author: Hweinstock

packages/core/src/shared/awsClientBuilderV3.ts

@@ -112,12 +112,12 @@ export class AWSClientBuilderV3 {
     public async createAwsService<C extends AwsClient>(serviceOptions: AwsServiceOptions<C>): Promise<C> {
         const shim = this.getShim()
         const opt = (serviceOptions.clientOptions ?? {}) as AwsClientOptions
-
+        const userAgent = serviceOptions.userAgent ?? true
         if (!opt.region && serviceOptions.region) {
             opt.region = serviceOptions.region
         }
 
-        if (!opt.userAgent && serviceOptions.userAgent) {
+        if (!opt.userAgent && userAgent) {
             opt.userAgent = [[getUserAgent({ includePlatform: true, includeClientId: true }), extensionVersion]]
         }
 

packages/core/src/shared/clients/clientWrapper.ts

@@ -16,9 +16,10 @@ export abstract class ClientWrapper<C extends AwsClient> implements vscode.Dispo
     ) {}
 
     protected async getClient(ignoreCache: boolean = false) {
+        const args = { serviceClient: this.clientType, region: this.regionCode }
         return ignoreCache
-            ? await globals.sdkClientBuilderV3.createAwsService(this.clientType, undefined, this.regionCode)
-            : await globals.sdkClientBuilderV3.getAwsService(this.clientType, undefined, this.regionCode)
+            ? await globals.sdkClientBuilderV3.createAwsService(args)
+            : await globals.sdkClientBuilderV3.getAwsService(args)
     }
 
     protected async makeRequest<CommandInput extends object, Command extends AwsCommand>(