refactor(secretsmanager): migrate to aws sdk v3 (#8095)

## Problem

AWS SDK V2 is at EOL.


## Solution

Migrate SecretsManager client to V3


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

Author: ctlai95

package-lock.json

@@ -591,6 +591,7 @@
         "@aws-sdk/client-s3-control": "^3.830.0",
         "@aws-sdk/client-sagemaker": "<3.696.0",
         "@aws-sdk/client-schemas": "~3.693.0",
+        "@aws-sdk/client-secrets-manager": "~3.693.0",
         "@aws-sdk/client-sfn": "<3.731.0",
         "@aws-sdk/client-ssm": "<3.731.0",
         "@aws-sdk/client-sso": "<3.731.0",

packages/core/package.json

@@ -16,7 +16,7 @@ import { RegionProvider } from '../../../shared/regions/regionProvider'
 import { createRegionPrompter } from '../../../shared/ui/common/region'
 import { ClustersMessage } from 'aws-sdk/clients/redshift'
 import { Prompter } from '../../../shared/ui/prompter'
-import { ListSecretsResponse } from 'aws-sdk/clients/secretsmanager'
+import { ListSecretsResponse } from '@aws-sdk/client-secrets-manager'
 import { SecretsManagerClient } from '../../../shared/clients/secretsManagerClient'
 import { redshiftHelpUrl } from '../../../shared/constants'
 

packages/core/src/awsService/redshift/wizards/connectionWizard.ts

@@ -3,22 +3,24 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import { SecretsManager } from 'aws-sdk'
-import globals from '../extensionGlobals'
 import {
+    CreateSecretCommand,
     CreateSecretRequest,
     CreateSecretResponse,
+    ListSecretsCommand,
     ListSecretsRequest,
     ListSecretsResponse,
-} from 'aws-sdk/clients/secretsmanager'
+    SecretsManagerClient as SecretsManagerSdkClient,
+} from '@aws-sdk/client-secrets-manager'
+import globals from '../extensionGlobals'
 import { productName } from '../constants'
 
 export class SecretsManagerClient {
     public constructor(
         public readonly regionCode: string,
         private readonly secretsManagerClientProvider: (
             regionCode: string
-        ) => Promise<SecretsManager> = createSecretsManagerClient
+        ) => SecretsManagerSdkClient = createSecretsManagerClient
     ) {}
 
     /**
@@ -27,7 +29,7 @@ export class SecretsManagerClient {
      * @returns a list of the secrets
      */
     public async listSecrets(filter: string): Promise<ListSecretsResponse> {
-        const secretsManagerClient = await this.secretsManagerClientProvider(this.regionCode)
+        const secretsManagerClient = this.secretsManagerClientProvider(this.regionCode)
         const request: ListSecretsRequest = {
             IncludePlannedDeletion: false,
             Filters: [
@@ -38,11 +40,11 @@ export class SecretsManagerClient {
             ],
             SortOrder: 'desc',
         }
-        return secretsManagerClient.listSecrets(request).promise()
+        return secretsManagerClient.send(new ListSecretsCommand(request))
     }
 
     public async createSecret(secretString: string, username: string, password: string): Promise<CreateSecretResponse> {
-        const secretsManagerClient = await this.secretsManagerClientProvider(this.regionCode)
+        const secretsManagerClient = this.secretsManagerClientProvider(this.regionCode)
         const request: CreateSecretRequest = {
             Description: `Database secret created with ${productName}`,
             Name: secretString ? secretString : '',
@@ -59,10 +61,13 @@ export class SecretsManagerClient {
             ],
             ForceOverwriteReplicaSecret: true,
         }
-        return secretsManagerClient.createSecret(request).promise()
+        return secretsManagerClient.send(new CreateSecretCommand(request))
     }
 }
 
-async function createSecretsManagerClient(regionCode: string): Promise<SecretsManager> {
-    return await globals.sdkClientBuilder.createAwsService(SecretsManager, { computeChecksums: true }, regionCode)
+function createSecretsManagerClient(regionCode: string): SecretsManagerSdkClient {
+    return globals.sdkClientBuilderV3.createAwsService({
+        serviceClient: SecretsManagerSdkClient,
+        clientOptions: { region: regionCode },
+    })
 }