Merge branch 'implement_rules' of https://github.com/laura-codess/aws-toolkit-vscode into implement_rules

Author: laura-codess

package-lock.json

@@ -30,7 +30,7 @@ describe('Amazon Q Rules Functionality', function () {
         const workbench = testContext.workbench
         await workbench.executeCommand('Amazon Q: Open Chat')
 
-        // sleep is needed                  because the workbench needs some time to load
+        // sleep is needed because the workbench needs some time to load
         await sleep(5000)
         const activityBar = new ActivityBar()
         const amazonQControl = await activityBar.getViewControl('Amazon Q')

packages/amazonq/test/e2e_new/amazonq/tests/rules.test.ts

@@ -20,7 +20,7 @@ export async function sleep(timeout: number) {
  * @param timeout The timeout in milliseconds (Optional)
  * @returns Promise<WebElement> Returns the element found
  */
-export async function waitForElement(webview: WebviewView, locator: By, timeout: number = 8000): Promise<WebElement> {
+export async function waitForElement(webview: WebviewView, locator: By, timeout?: number): Promise<WebElement> {
     const driver = webview.getDriver()
     await driver.wait(until.elementsLocated(locator), timeout)
     return await webview.findWebElement(locator)
@@ -33,11 +33,7 @@ export async function waitForElement(webview: WebviewView, locator: By, timeout:
  * @param timeout The timeout in milliseconds (Optional)
  * @returns Promise<WebElement[]> Returns an array of elements found
  */
-export async function waitForElements(
-    webview: WebviewView,
-    locator: By,
-    timeout: number = 8000
-): Promise<WebElement[]> {
+export async function waitForElements(webview: WebviewView, locator: By, timeout?: number): Promise<WebElement[]> {
     const driver = webview.getDriver()
     await driver.wait(until.elementsLocated(locator), timeout)
     return await webview.findWebElements(locator)