Skip to content

Commit 7510932

Browse files
author
David Hasani
committed
remove duplicate metric
1 parent 879ca36 commit 7510932

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

packages/core/src/codewhisperer/commands/startTransformByQ.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -597,9 +597,6 @@ export async function startTransformationJob(uploadId: string, transformStartTim
597597
telemetry.record({
598598
codeTransformJobId: jobId,
599599
codeTransformRunTimeLatency: calculateTotalLatency(transformStartTime),
600-
codeTransformTarget: transformByQState.getMetadataPathSQL()
601-
? transformByQState.getTargetDB()
602-
: transformByQState.getTargetJDKVersion(),
603600
})
604601
})
605602
} catch (error) {

packages/core/src/codewhisperer/models/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ export const buildCodeStepMessage = 'Build uploaded code in secure build environ
452452

453453
export const generatePlanStepMessage = 'Generate transformation plan'
454454

455-
export const transformStepMessage = 'Transform your code to Java 17'
455+
export const transformStepMessage = 'Transform your code'
456456

457457
export const filesUploadedMessage =
458458
'Files have been uploaded to Amazon Q, transformation job has been accepted and is preparing to start.'

packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,11 @@ export async function zipCode(
321321
getLogger().info(`CodeTransformation: source code files size = ${sourceFilesSize}`)
322322
}
323323

324-
if (transformByQState.getMetadataPathSQL() && zipManifest instanceof ZipManifest) {
325-
// user is doing a SQL conversion since metadataPath is defined
326-
// also, it must be a ZipManifest since only other option is HilZipManifest which is not used for SQL conversions
324+
if (
325+
transformByQState.getTransformationType() === TransformationType.SQL_CONVERSION &&
326+
zipManifest instanceof ZipManifest
327+
) {
328+
// note that zipManifest must be a ZipManifest since only other option is HilZipManifest which is not used for SQL conversions
327329
const metadataZip = new AdmZip(transformByQState.getMetadataPathSQL())
328330
zipManifest.requestedConversions.sqlConversion = {
329331
source: transformByQState.getSourceDB(),
@@ -332,7 +334,7 @@ export async function zipCode(
332334
host: transformByQState.getSourceServerName(),
333335
sctFileName: metadataZip.getEntries().filter((entry) => entry.entryName.endsWith('.sct'))[0].entryName,
334336
}
335-
// TO-DO: later make this add to path.join(zipManifest.dependenciesRoot, 'qct-sct-metadata', entry.entryName) so that it's more organized
337+
// TO-DO: later consider making this add to path.join(zipManifest.dependenciesRoot, 'qct-sct-metadata', entry.entryName) so that it's more organized
336338
metadataZip
337339
.getEntries()
338340
.forEach((entry) =>

0 commit comments

Comments
 (0)