codewhisperer: remove trailing / or # from startUrl #3612

This is for the consistency of such value for telemetry

Author: andrewyuq

src/codewhisperer/util/authUtil.ts

@@ -66,7 +66,11 @@ export class AuthUtil {
             } else {
                 this.usingEnterpriseSSO = false
             }
-            TelemetryHelper.instance.startUrl = isSsoConnection(this.conn) ? this.conn?.startUrl : undefined
+            // Reformat the url to remove any trailing '/' and `#`
+            // e.g. https://view.awsapps.com/start/# will become https://view.awsapps.com/start
+            TelemetryHelper.instance.startUrl = isSsoConnection(this.conn)
+                ? this.reformatStartUrl(this.conn?.startUrl)
+                : undefined
             await Promise.all([
                 vscode.commands.executeCommand('aws.codeWhisperer.refresh'),
                 vscode.commands.executeCommand('aws.codeWhisperer.refreshRootNode'),
@@ -78,6 +82,10 @@ export class AuthUtil {
         })
     }
 
+    public reformatStartUrl(startUrl: string | undefined) {
+        return !startUrl ? undefined : startUrl.replace(/[\/#]+$/g, '')
+    }
+
     // current active cwspr connection
     public get conn() {
         return this.secondaryAuth.activeConnection

src/test/codewhisperer/util/authUtil.test.ts

@@ -134,4 +134,14 @@ describe('AuthUtil', async function () {
         assert.strictEqual(authUtil.conn.ssoRegion, upgradeableConn.ssoRegion)
         assert.strictEqual((await auth.listConnections()).filter(isSsoConnection).length, 1)
     })
+
+    it('test reformatStartUrl should remove trailing slash and hash', function () {
+        const expected = 'https://view.awsapps.com/start'
+        assert.strictEqual(authUtil.reformatStartUrl(expected + '/'), expected)
+        assert.strictEqual(authUtil.reformatStartUrl(undefined), undefined)
+        assert.strictEqual(authUtil.reformatStartUrl(expected + '/#'), expected)
+        assert.strictEqual(authUtil.reformatStartUrl(expected + '#/'), expected)
+        assert.strictEqual(authUtil.reformatStartUrl(expected + '/#/'), expected)
+        assert.strictEqual(authUtil.reformatStartUrl(expected + '####'), expected)
+    })
 })