Skip to content

Commit 76c88fd

Browse files
authored
Gsweet/remove default sentiment (#1147)
* Removed default sentiment from quick feedback, made it required * removed unnecessary commas * attempting to remove commas
1 parent 9231bf0 commit 76c88fd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

media/js/submitFeedbackVue.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ console.log('Loaded!')
55
el: '#app',
66
data: {
77
comment: '',
8-
sentiment: 'Positive',
8+
sentiment: '',
99
isSubmitting: false,
10-
error: ''
10+
error: '',
1111
},
1212
mounted() {
1313
this.$nextTick(function() {
@@ -32,9 +32,9 @@ console.log('Loaded!')
3232
vscode.postMessage({
3333
command: 'submitFeedback',
3434
comment: this.comment,
35-
sentiment: this.sentiment
35+
sentiment: this.sentiment,
3636
})
37-
}
38-
}
37+
},
38+
},
3939
})
4040
})()

src/feedback/templates/feedbackTemplates.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export class FeedbackTemplates {
3030
<a href="https://github.com/aws/aws-toolkit-vscode/issues/new/choose">Talk to us on GitHub instead!</a></p>
3131
3232
<input v-if="isSubmitting" type="submit" value="Submitting..." disabled>
33-
<input v-else type="submit" @click="submitFeedback" :disabled="comment.length === 0 || comment.length > 2000" value="Submit">
33+
<input v-else type="submit" @click="submitFeedback" :disabled="comment.length === 0 || comment.length > 2000 || sentiment === ''" value="Submit">
3434
3535
<div id="error" v-if="error !== ''">
3636
<strong>{{ error }}</strong>

0 commit comments

Comments
 (0)