Commit 7bb66e1
authored
feat(amazonq): Port in chat message error handling (#7121)
## Problem
During the agentic loop, if there are multiple iterations and then it
eventually fails, the partial results would not be posted and the user
would not be able to continue chat (it wouldn't allow them to type)
## Solution
Port in the VSC client related change from:
aws/language-servers#1012
Now if there are errors during the agentic loop, we will display all the
partial responses we have gathered and then break out of the generating
state, allowing the user to continue.
## How I tested
Between the previous and new changes I ran the same test suite
- Ask agentic chat to make 101 files (since [a recent
change](aws/language-servers#1022) increased the
loop limit to 100) in a test folder, adding in some random text
- Ask agentic chat to "read every single file, not skipping any of them,
and then display the text of each one".
- W/ the old changes it would error part way and the UI would show
"generating" and the user could not do anything
- W/ the new changes it will show partial results (the text of the files
it could resolve) and then allow the user to continue with another
prompt.
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Signed-off-by: nkomonen-amazon <[email protected]>1 parent 1e48e36 commit 7bb66e1
1 file changed
+47
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
186 | 186 | | |
187 | | - | |
188 | | - | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
189 | 203 | | |
190 | 204 | | |
191 | 205 | | |
| |||
197 | 211 | | |
198 | 212 | | |
199 | 213 | | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
211 | 244 | | |
212 | 245 | | |
213 | 246 | | |
| |||
0 commit comments