feat(amazonq): select chat history item on enter key press

Author: avi-alpert

package-lock.json

@@ -499,6 +499,7 @@
         "@amzn/amazon-q-developer-streaming-client": "file:../../src.gen/@amzn/amazon-q-developer-streaming-client",
         "@amzn/codewhisperer-streaming": "file:../../src.gen/@amzn/codewhisperer-streaming",
         "@aws-sdk/client-api-gateway": "<3.731.0",
+        "@aws-sdk/client-apprunner": "<3.731.0",
         "@aws-sdk/client-cloudcontrol": "<3.731.0",
         "@aws-sdk/client-cloudformation": "<3.731.0",
         "@aws-sdk/client-cloudwatch-logs": "<3.731.0",
@@ -513,7 +514,6 @@
         "@aws-sdk/client-ssm": "<3.731.0",
         "@aws-sdk/client-sso": "<3.731.0",
         "@aws-sdk/client-sso-oidc": "<3.731.0",
-        "@aws-sdk/client-apprunner": "<3.731.0",
         "@aws-sdk/credential-provider-env": "<3.731.0",
         "@aws-sdk/credential-provider-process": "<3.731.0",
         "@aws-sdk/credential-provider-sso": "<3.731.0",
@@ -523,7 +523,7 @@
         "@aws-sdk/s3-request-presigner": "<3.731.0",
         "@aws-sdk/smithy-client": "<3.731.0",
         "@aws-sdk/util-arn-parser": "<3.731.0",
-        "@aws/mynah-ui": "^4.27.0-beta.3",
+        "@aws/mynah-ui": "^4.27.0",
         "@gerhobbelt/gitignore-parser": "^0.2.0-9",
         "@iarna/toml": "^2.2.5",
         "@smithy/fetch-http-handler": "^5.0.1",

packages/core/package.json

@@ -37,6 +37,7 @@ export interface BaseConnectorProps {
         update: (data: DetailedList) => void
         close: () => void
         changeTarget: (direction: 'up' | 'down', snapOnLastAndFirst?: boolean) => void
+        getTargetElementId: () => string | undefined
     }
     onSelectTab: (tabID: string, eventID: string) => void
     onExportChat: (tabId: string, format: 'html' | 'markdown') => string

packages/core/src/amazonq/webview/ui/apps/baseConnector.ts

@@ -112,6 +112,7 @@ export interface ConnectorProps {
         update: (data: DetailedList) => void
         close: () => void
         changeTarget: (direction: 'up' | 'down', snapOnLastAndFirst?: boolean) => void
+        getTargetElementId: () => string | undefined
     }
     onSelectTab: (tabID: string, eventID: string) => void
     onExportChat: (tabID: string, format: 'markdown' | 'html') => string

packages/core/src/amazonq/webview/ui/connector.ts

@@ -17,10 +17,14 @@ export class DetailedListConnector {
         update: (data: DetailedList) => void
         close: () => void
         changeTarget: (direction: 'up' | 'down', snapOnLastAndFirst?: boolean) => void
+        getTargetElementId: () => string | undefined
     }
     closeList() {}
     updateList(_data: DetailedList) {}
     changeTarget(_direction: 'up' | 'down', _snapOnLastAndFirst?: boolean) {}
+    getTargetElementId(): string | undefined {
+        return undefined
+    }
 
     constructor(
         type: DetailedListType,
@@ -29,6 +33,7 @@ export class DetailedListConnector {
             update: (data: DetailedList) => void
             close: () => void
             changeTarget: (direction: 'up' | 'down', snapOnLastAndFirst?: boolean) => void
+            getTargetElementId: () => string | undefined
         }
     ) {
         this.type = type
@@ -37,7 +42,7 @@ export class DetailedListConnector {
     }
 
     openList(messageData: any) {
-        const { update, close, changeTarget } = this.onOpenDetailedList({
+        const { update, close, changeTarget, getTargetElementId } = this.onOpenDetailedList({
             tabId: messageData.tabID,
             detailedList: messageData.detailedList,
             events: {
@@ -50,6 +55,7 @@ export class DetailedListConnector {
         this.closeList = close
         this.updateList = update
         this.changeTarget = changeTarget
+        this.getTargetElementId = getTargetElementId
     }
 
     onFilterValueChange = (filterValues: Record<string, any>, isValid: boolean) => {
@@ -84,7 +90,12 @@ export class DetailedListConnector {
         if (e.key === 'Escape') {
             this.closeList()
         } else if (e.key === 'Enter') {
-            // todo: call onItemSelect on Enter
+            const targetElementId = this.getTargetElementId()
+            if (targetElementId) {
+                this.onItemSelect({
+                    id: targetElementId,
+                })
+            }
         } else if (e.key === 'ArrowUp') {
             this.changeTarget('up')
         } else if (e.key === 'ArrowDown') {

packages/core/src/amazonq/webview/ui/detailedList/detailedListConnector.ts

@@ -966,10 +966,12 @@ export const createMynahUI = (
                 {
                     id: 'history_sheet',
                     icon: MynahIcons.COMMENT,
+                    description: 'View chat history',
                 },
                 {
                     id: 'export_chat',
                     icon: MynahIcons.EXTERNAL,
+                    description: 'Export chat',
                 },
             ],
         },

packages/core/src/amazonq/webview/ui/main.ts

@@ -52,7 +52,7 @@ export class Database {
             autosave: true,
             autoload: true,
             autoloadCallback: () => this.databaseInitialize(),
-            autosaveInterval: 4000,
+            autosaveInterval: 1000,
             persistenceMethod: 'fs',
         })
     }
@@ -201,9 +201,6 @@ export class Database {
         return []
     }
 
-    /**
-     * Returns DetailedListItemGroup[]
-     */
     getHistory(): DetailedListItemGroup[] {
         if (this.initialized) {
             const tabCollection = this.db.getCollection<Tab>(TabCollection)
@@ -217,6 +214,10 @@ export class Database {
         if (this.initialized) {
             const tabCollection = this.db.getCollection<Tab>(TabCollection)
             tabCollection.findAndRemove({ historyId })
+            const tabId = this.getTabId(historyId)
+            if (tabId) {
+                this.historyIdMapping.delete(tabId)
+            }
         }
     }