Skip to content

Commit 7c8d60f

Browse files
committed
Remove STS cache watcher
1 parent a79939a commit 7c8d60f

File tree

4 files changed

+1
-30
lines changed

4 files changed

+1
-30
lines changed

packages/core/src/auth/auth2.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ import { LanguageClient } from 'vscode-languageclient'
5656
import { getLogger } from '../shared/logger/logger'
5757
import { ToolkitError } from '../shared/errors'
5858
import { useDeviceFlow } from './sso/ssoAccessTokenProvider'
59-
import { getCacheDir, getCacheFileWatcher, getFlareCacheFileName, getStsCacheDir } from './sso/cache'
59+
import { getCacheDir, getCacheFileWatcher, getFlareCacheFileName } from './sso/cache'
6060
import { VSCODE_EXTENSION_ID } from '../shared/extensions'
6161
import { IamCredentials } from '@aws/language-server-runtimes-types'
6262
import globals from '../shared/extensionGlobals'
@@ -88,8 +88,6 @@ export type LoginType = (typeof LoginTypes)[keyof typeof LoginTypes]
8888

8989
export type cacheChangedEvent = 'delete' | 'create'
9090

91-
export type stsCacheChangedEvent = 'delete' | 'create'
92-
9391
export type Login = SsoLogin | IamLogin
9492

9593
export type TokenSource = IamIdentityCenterSsoTokenSource | AwsBuilderIdSsoTokenSource
@@ -115,10 +113,6 @@ const IamProfileOptionsDefaults = {
115113
*/
116114
export class LanguageClientAuth {
117115
readonly #ssoCacheWatcher = getCacheFileWatcher(getCacheDir(), getFlareCacheFileName(VSCODE_EXTENSION_ID.amazonq))
118-
readonly #stsCacheWatcher = getCacheFileWatcher(
119-
getStsCacheDir(),
120-
getFlareCacheFileName(VSCODE_EXTENSION_ID.amazonq)
121-
)
122116

123117
constructor(
124118
private readonly client: LanguageClient,
@@ -130,10 +124,6 @@ export class LanguageClientAuth {
130124
return this.#ssoCacheWatcher
131125
}
132126

133-
public get stsCacheWatcher() {
134-
return this.#stsCacheWatcher
135-
}
136-
137127
/**
138128
* Encrypts an object
139129
*/
@@ -324,11 +314,6 @@ export class LanguageClientAuth {
324314
this.cacheWatcher.onDidCreate(() => cacheChangedHandler('create'))
325315
this.cacheWatcher.onDidDelete(() => cacheChangedHandler('delete'))
326316
}
327-
328-
registerStsCacheWatcher(stsCacheChangedHandler: (event: stsCacheChangedEvent) => any) {
329-
this.stsCacheWatcher.onDidCreate(() => stsCacheChangedHandler('create'))
330-
this.stsCacheWatcher.onDidDelete(() => stsCacheChangedHandler('delete'))
331-
}
332317
}
333318

334319
/**

packages/core/src/auth/sso/cache.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ export interface SsoCache {
3636
}
3737

3838
const defaultCacheDir = () => path.join(fs.getUserHomeDir(), '.aws/sso/cache')
39-
const defaultStsCacheDir = () => path.join(fs.getUserHomeDir(), '.aws/flare/cache')
4039
export const getCacheDir = () => DevSettings.instance.get('ssoCacheDirectory', defaultCacheDir())
41-
export const getStsCacheDir = () => DevSettings.instance.get('stsCacheDirectory', defaultStsCacheDir())
4240

4341
export function getCache(directory = getCacheDir()): SsoCache {
4442
return {

packages/core/src/codewhisperer/util/authUtil.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import { telemetry } from '../../shared/telemetry/telemetry'
3333
import {
3434
AuthStateEvent,
3535
cacheChangedEvent,
36-
stsCacheChangedEvent,
3736
LanguageClientAuth,
3837
Login,
3938
SsoLogin,
@@ -118,7 +117,6 @@ export class AuthUtil implements IAuthProvider {
118117
await this.setVscodeContextProps()
119118
})
120119
lspAuth.registerCacheWatcher(async (event: cacheChangedEvent) => await this.cacheChangedHandler(event))
121-
lspAuth.registerStsCacheWatcher(async (event: stsCacheChangedEvent) => await this.stsCacheChangedHandler(event))
122120
}
123121

124122
// Do NOT use this in production code, only used for testing
@@ -365,15 +363,6 @@ export class AuthUtil implements IAuthProvider {
365363
}
366364
}
367365

368-
private async stsCacheChangedHandler(event: stsCacheChangedEvent) {
369-
this.logger.debug(`Sts Cache change event received: ${event}`)
370-
if (event === 'delete') {
371-
await this.logout()
372-
} else if (event === 'create') {
373-
await this.restore()
374-
}
375-
}
376-
377366
private async stateChangeHandler(e: AuthStateEvent) {
378367
if (e.state === 'refreshed') {
379368
if (this.isSsoSession()) {

packages/core/src/test/testAuthUtil.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ export async function createTestAuthUtil() {
5353
updateIamCredential: sinon.stub().resolves(),
5454
invalidateSsoToken: sinon.stub().resolves(),
5555
registerCacheWatcher: sinon.stub().resolves(),
56-
registerStsCacheWatcher: sinon.stub().resolves(),
5756
encryptionKey,
5857
}
5958

0 commit comments

Comments
 (0)