Skip to content

Commit 7d29127

Browse files
committed
add logging
1 parent 5450d47 commit 7d29127

File tree

2 files changed

+34
-23
lines changed

2 files changed

+34
-23
lines changed

packages/core/src/applicationcomposer/messageHandlers/generateResourceHandler.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,15 @@ import {
1818
} from '../types'
1919
import globals from '../../shared/extensionGlobals'
2020
import { getLogger } from '../../shared/logger/logger'
21-
import { AmazonqNotFoundError, getAmazonqApi } from '../../amazonq/extApi'
21+
import * as extApi from '../../amazonq/extApi'
2222

2323
const TIMEOUT = 30_000
2424

2525
export async function generateResourceHandler(request: GenerateResourceRequestMessage, context: WebviewContext) {
2626
try {
2727
const { chatResponse, references, metadata, isSuccess } = await generateResource(request.cfnType)
28-
28+
// eslint-disable-next-line aws-toolkits/no-console-log
29+
console.log('post-generateResource')
2930
const responseMessage: GenerateResourceResponseMessage = {
3031
command: Command.GENERATE_RESOURCE,
3132
messageType: MessageType.RESPONSE,
@@ -58,9 +59,11 @@ async function generateResource(cfnType: string) {
5859
let startTime = globals.clock.Date.now()
5960

6061
try {
61-
const amazonqApi = await getAmazonqApi()
62+
const amazonqApi = await extApi.getAmazonqApi()
63+
// eslint-disable-next-line aws-toolkits/no-console-log
64+
console.log('post-getAmazonQApi')
6265
if (!amazonqApi) {
63-
throw new AmazonqNotFoundError()
66+
throw new extApi.AmazonqNotFoundError()
6467
}
6568
const request: GenerateAssistantResponseRequest = {
6669
conversationState: {
@@ -81,6 +84,8 @@ async function generateResource(cfnType: string) {
8184
let references: Reference[] = []
8285

8386
await amazonqApi.authApi.reauthIfNeeded()
87+
// eslint-disable-next-line aws-toolkits/no-console-log
88+
console.log('post-reauthIfNeeded')
8489

8590
startTime = globals.clock.Date.now()
8691
// TODO-STARLING - Revisit to see if timeout still needed prior to launch

packages/core/src/test/applicationcomposer/messageHandlers/generateResourceHandler.test.ts

Lines changed: 25 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,29 +8,35 @@ import sinon from 'sinon'
88
import { createTemplate, createWebviewContext } from '../utils'
99
import { generateResourceHandler } from '../../../applicationcomposer/messageHandlers/generateResourceHandler'
1010
import { Command, MessageType } from '../../../applicationcomposer/types'
11+
import * as extApi from '../../../amazonq/extApi'
1112

1213
describe('generateResourceHandler', function () {
1314
afterEach(() => {
1415
sinon.restore()
1516
})
16-
17-
it('amazon q is not installed', async () => {
18-
const panel = await createTemplate()
19-
const postMessageSpy = sinon.spy(panel.webview, 'postMessage')
20-
const context = await createWebviewContext({
21-
panel,
17+
for (const _ of Array.from({ length: 20 }, (i) => i)) {
18+
it('amazon q is not installed', async () => {
19+
sinon.stub(extApi, 'getAmazonqApi')
20+
const panel = await createTemplate()
21+
console.log('post-createTemplate')
22+
const postMessageSpy = sinon.spy(panel.webview, 'postMessage')
23+
const context = await createWebviewContext({
24+
panel,
25+
})
26+
console.log('post-createWebviewContext')
27+
await generateResourceHandler(
28+
{
29+
command: Command.GENERATE_RESOURCE,
30+
messageType: MessageType.REQUEST,
31+
cfnType: '',
32+
prompt: '',
33+
traceId: '0',
34+
},
35+
context
36+
)
37+
console.log('post-generateResourceHandler')
38+
assert.ok(postMessageSpy.calledOnce)
39+
assert.deepStrictEqual(postMessageSpy.getCall(0).args[0].isSuccess, false)
2240
})
23-
await generateResourceHandler(
24-
{
25-
command: Command.GENERATE_RESOURCE,
26-
messageType: MessageType.REQUEST,
27-
cfnType: '',
28-
prompt: '',
29-
traceId: '0',
30-
},
31-
context
32-
)
33-
assert.ok(postMessageSpy.calledOnce)
34-
assert.deepStrictEqual(postMessageSpy.getCall(0).args[0].isSuccess, false)
35-
})
41+
}
3642
})

0 commit comments

Comments
 (0)