limit commands to cases where they are dont throw error

Author: Hweinstock

package.json

@@ -1327,42 +1327,42 @@
                 {
                     "command": "aws.ec2.openTerminal",
                     "group": "0@1",
-                    "when": "viewItem == awsEc2Node"
+                    "when": "viewItem =~ /^(awsEc2(Parent|Running|Stopped|Pending)Node)$/"
                 },
                 {
                     "command": "aws.ec2.openTerminal",
                     "group": "inline@1",
-                    "when": "viewItem == awsEc2Node"
+                    "when": "viewItem =~ /^(awsEc2(Parent|Running|Stopped|Pending)Node)$/"
                 },
                 {
                     "command": "aws.ec2.startInstance",
                     "group": "0@1",
-                    "when": "viewItem == awsEc2Node"
+                    "when": "viewItem =~ /^(awsEc2(Stopped|Pending)Node)$/"
                 },
                 {
                     "command": "aws.ec2.startInstance",
                     "group": "inline@1",
-                    "when": "viewItem == awsEc2Node"
+                    "when": "viewItem =~ /^(awsEc2(Stopped|Pending)Node)$/"
                 },
                 {
                     "command": "aws.ec2.stopInstance",
                     "group": "0@1",
-                    "when": "viewItem == awsEc2Node"
+                    "when": "viewItem =~ /^(awsEc2(Running|Pending)Node)$/"
                 },
                 {
                     "command": "aws.ec2.stopInstance",
                     "group": "inline@1",
-                    "when": "viewItem == awsEc2Node"
+                    "when": "viewItem =~ /^(awsEc2(Running|Pending)Node)$/"
                 },
                 {
                     "command": "aws.ec2.rebootInstance",
                     "group": "0@1",
-                    "when": "viewItem == awsEc2Node"
+                    "when": "viewItem =~ /^(awsEc2(Running|Pending)Node)$/"
                 },
                 {
                     "command": "aws.ec2.rebootInstance",
                     "group": "inline@1",
-                    "when": "viewItem == awsEc2Node"
+                    "when": "viewItem =~ /^(awsEc2(Running|Pending)Node)$/"
                 },
                 {
                     "command": "aws.ecr.createRepository",

src/ec2/explorer/ec2InstanceNode.ts

@@ -10,12 +10,13 @@ import { Ec2Instance } from '../../shared/clients/ec2Client'
 import globals from '../../shared/extensionGlobals'
 import { Ec2Selection, getIconCodeForInstanceStatus } from '../utils'
 
+type Ec2InstanceNodeContext = 'awsEc2RunningNode' | 'awsEc2StoppedNode' | 'awsEc2PendingNode'
+
 export class Ec2InstanceNode extends AWSTreeNodeBase implements AWSResourceNode {
     public constructor(
         public override readonly regionCode: string,
         private readonly partitionId: string,
-        private instance: Ec2Instance,
-        public override readonly contextValue: string
+        private instance: Ec2Instance
     ) {
         super('')
         this.update(instance)
@@ -24,10 +25,23 @@ export class Ec2InstanceNode extends AWSTreeNodeBase implements AWSResourceNode
     public update(newInstance: Ec2Instance) {
         this.setInstance(newInstance)
         this.label = `${this.name} (${this.InstanceId})`
+        this.contextValue = this.getContext()
         this.iconPath = new vscode.ThemeIcon(getIconCodeForInstanceStatus(this.instance))
         this.tooltip = `${this.name}\n${this.InstanceId}\n${this.instance.status}\n${this.arn}`
     }
 
+    private getContext(): Ec2InstanceNodeContext {
+        if (this.instance.status == 'running') {
+            return 'awsEc2RunningNode'
+        }
+
+        if (this.instance.status == 'stopped') {
+            return 'awsEc2StoppedNode'
+        }
+
+        return 'awsEc2PendingNode'
+    }
+
     public setInstance(newInstance: Ec2Instance) {
         this.instance = newInstance
     }

src/ec2/explorer/ec2ParentNode.ts

@@ -10,13 +10,13 @@ import { Ec2InstanceNode } from './ec2InstanceNode'
 import { Ec2Client } from '../../shared/clients/ec2Client'
 import { updateInPlace } from '../../shared/utilities/collectionUtils'
 
-export const contextValueEc2 = 'awsEc2Node'
+export const parentContextValue = 'awsEc2ParentNode'
 export type Ec2Node = Ec2InstanceNode | Ec2ParentNode
 
 export class Ec2ParentNode extends AWSTreeNodeBase {
     protected readonly placeHolderMessage = '[No EC2 Instances Found]'
     protected readonly ec2InstanceNodes: Map<string, Ec2InstanceNode>
-    public override readonly contextValue: string = contextValueEc2
+    public override readonly contextValue: string = parentContextValue
 
     public constructor(
         public override readonly regionCode: string,
@@ -45,7 +45,7 @@ export class Ec2ParentNode extends AWSTreeNodeBase {
             this.ec2InstanceNodes,
             ec2Instances.keys(),
             key => this.ec2InstanceNodes.get(key)!.update(ec2Instances.get(key)!),
-            key => new Ec2InstanceNode(this.regionCode, this.partitionId, ec2Instances.get(key)!, contextValueEc2)
+            key => new Ec2InstanceNode(this.regionCode, this.partitionId, ec2Instances.get(key)!)
         )
     }
 }

src/test/ec2/explorer/ec2InstanceNode.test.ts

@@ -6,7 +6,7 @@
 import * as assert from 'assert'
 import { Ec2InstanceNode } from '../../../ec2/explorer/ec2InstanceNode'
 import { Ec2Instance, getNameOfInstance } from '../../../shared/clients/ec2Client'
-import { contextValueEc2 } from '../../../ec2/explorer/ec2ParentNode'
+import { parentContextValue } from '../../../ec2/explorer/ec2ParentNode'
 
 describe('ec2InstanceNode', function () {
     let testNode: Ec2InstanceNode
@@ -23,7 +23,7 @@ describe('ec2InstanceNode', function () {
             ],
         }
 
-        testNode = new Ec2InstanceNode('testRegion', 'testPartition', testInstance, contextValueEc2)
+        testNode = new Ec2InstanceNode('testRegion', 'testPartition', testInstance, parentContextValue)
     })
 
     it('instantiates without issue', async function () {

src/test/ec2/explorer/ec2ParentNode.test.ts

@@ -4,7 +4,7 @@
  */
 
 import * as assert from 'assert'
-import { Ec2ParentNode, contextValueEc2 } from '../../../ec2/explorer/ec2ParentNode'
+import { Ec2ParentNode, parentContextValue } from '../../../ec2/explorer/ec2ParentNode'
 import { stub } from '../../utilities/stubber'
 import { Ec2Client, Ec2Instance } from '../../../shared/clients/ec2Client'
 import { intoCollection } from '../../../shared/utilities/collectionUtils'
@@ -65,7 +65,7 @@ describe('ec2ParentNode', function () {
         const childNodes = await testNode.getChildren()
 
         childNodes.forEach(node =>
-            assert.strictEqual(node.contextValue, contextValueEc2, 'expected the node to have a ec2 contextValue')
+            assert.strictEqual(node.contextValue, parentContextValue, 'expected the node to have a ec2 contextValue')
         )
     })