Toolkit now updates the logger's logging level when Configuration changes are made (#878)

* Toolkit now updates the logger's logging level when Configuration changes are made (instead of requiring a VS Code restart)

Author: awschristou

.changes/next-release/Feature-d0c674fc-4f1d-4fa9-9f51-485de73fb9a2.json

@@ -0,0 +1,4 @@
+{
+    "type": "Feature",
+    "description": "The Toolkit now applies configuration changes to the log level when it changes instead of the next time the toolkit is started (#860)"
+}

src/extension.ts

@@ -38,7 +38,7 @@ export async function activate(context: vscode.ExtensionContext) {
     const localize = nls.loadMessageBundle()
 
     ext.context = context
-    await activateLogger()
+    await activateLogger(context)
     const toolkitOutputChannel = vscode.window.createOutputChannel(localize('AWS.channel.aws.toolkit', 'AWS Toolkit'))
 
     try {

src/shared/logger/activation.ts

@@ -26,14 +26,14 @@ const LOG_OUTPUT_CHANNEL: vscode.OutputChannel = vscode.window.createOutputChann
 /**
  * Activate Logger functionality for the extension.
  */
-export async function activate(): Promise<void> {
+export async function activate(extensionContext: vscode.ExtensionContext): Promise<void> {
     const outputChannel = LOG_OUTPUT_CHANNEL
     const logPath = LOG_PATH
     const logLevel = getLogLevel()
 
     await ensureLogFolderExists(path.dirname(logPath))
 
-    setLogger(makeLogger(logLevel, logPath, outputChannel))
+    setLogger(makeLogger(logLevel, logPath, outputChannel, extensionContext.subscriptions))
 
     await registerLoggerCommands()
 
@@ -42,11 +42,27 @@ export async function activate(): Promise<void> {
     )
 }
 
-export function makeLogger(logLevel: LogLevel, logPath: string, outputChannel: vscode.OutputChannel): Logger {
+export function makeLogger(
+    logLevel: LogLevel,
+    logPath: string,
+    outputChannel: vscode.OutputChannel,
+    disposables?: vscode.Disposable[]
+): Logger {
     const logger = new WinstonToolkitLogger(logLevel)
     logger.logToFile(logPath)
     logger.logToOutputChannel(outputChannel)
 
+    vscode.workspace.onDidChangeConfiguration(
+        configurationChangeEvent => {
+            if (configurationChangeEvent.affectsConfiguration('aws.logLevel')) {
+                const newLogLevel = vscode.workspace.getConfiguration('aws').get('logLevel', logLevel)
+                logger.setLogLevel(newLogLevel)
+            }
+        },
+        undefined,
+        disposables
+    )
+
     return logger
 }
 

src/shared/logger/winstonToolkitLogger.ts

@@ -46,8 +46,10 @@ export class WinstonToolkitLogger implements Logger, vscode.Disposable {
     }
 
     public setLogLevel(logLevel: LogLevel) {
-        this.logger.info(`Setting log level to: ${logLevel}`)
+        // Log calls are made with explicit levels to ensure the text is output
+        this.logger.log(this.logger.level, `Setting log level to: ${logLevel}`)
         this.logger.level = logLevel
+        this.logger.log(this.logger.level, `Log level is now: ${this.logger.level}`)
     }
 
     public logToFile(logPath: string): void {