Skip to content

Commit 819618e

Browse files
committed
switch to using isMinVscode
1 parent 2842ffd commit 819618e

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

packages/core/src/test/applicationcomposer/messageHandlers/generateResourceHandler.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,14 @@
55

66
import assert from 'assert'
77
import sinon from 'sinon'
8-
import semver from 'semver'
98
import { createTemplate, createWebviewContext } from '../utils'
109
import { generateResourceHandler } from '../../../applicationcomposer/messageHandlers/generateResourceHandler'
1110
import { Command, MessageType } from '../../../applicationcomposer/types'
1211
import * as env from '../../../shared/vscode/env'
1312

1413
describe('generateResourceHandler', function () {
1514
it('amazon q is not installed', async function () {
16-
if (isMinVscode('1.89.0')) {
15+
if (env.isMinVscode('1.89.0')) {
1716
this.skip()
1817
}
1918
const panel = await createTemplate()

packages/core/src/test/techdebt.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ describe('tech debt', function () {
2525
semver.lt(minVscode, '1.93.0'),
2626
'keepAlive works properly in vscode 1.93+. Remove src/codewhisperer/client/agent.ts and other code related to https://github.com/aws/aws-toolkit-vscode-staging/pull/1214'
2727
)
28-
29-
assert.ok(
30-
semver.lt(minVscode, '1.88.0'),
31-
'with vscode 1.88, we can remove the check in src/test/applicationcomposer/messageHandlers/generateResourceHandler.test.ts (generateResourceHandler: amazon q is not installed) test'
32-
)
3328
})
3429

3530
it('nodejs minimum version', async function () {

0 commit comments

Comments
 (0)