update calls to fs read

Author: Hweinstock

packages/core/src/shared/crashMonitoring.ts

@@ -506,7 +506,7 @@ export class FileSystemState {
                 // we will assume that other instance handled its termination appropriately.
                 const ext = await withFailCtx('parseRunningExtFile', async () =>
                     ignoreBadFileError(async () => {
-                        const text = await fs.readFileAsString(path.join(await this.runningExtsDir(), extId))
+                        const text = await fs.readFileText(path.join(await this.runningExtsDir(), extId))
 
                         if (!text) {
                             return undefined

packages/core/src/test/credentials/sso/cache.test.ts

@@ -47,7 +47,7 @@ describe('SSO Cache', function () {
             await cache.save({ startUrl, region }, validRegistration)
 
             const cachedPath = path.join(testDir, `aws-toolkit-vscode-client-id-${region}.json`)
-            const contents = await fs.readFileAsString(cachedPath)
+            const contents = await fs.readFileText(cachedPath)
 
             assert.deepStrictEqual(JSON.parse(contents), {
                 ...validRegistration,
@@ -70,7 +70,7 @@ describe('SSO Cache', function () {
 
             // SHA-1 hash of the encoded start URL `https://123456.awsapps.com/start`
             const cachedPath = path.join(testDir, 'c1ac99f782ad92755c6de8647b510ec247330ad1.json')
-            const contents = await fs.readFileAsString(cachedPath)
+            const contents = await fs.readFileText(cachedPath)
 
             assert.deepStrictEqual(JSON.parse(contents), {
                 region,

packages/core/src/test/shared/sam/debugger/samDebugConfigProvider.test.ts

@@ -2172,10 +2172,7 @@ describe('SamDebugConfigurationProvider', async function () {
             }
 
             assertEqualLaunchConfigs(actual, expected)
-            assert.strictEqual(
-                await fs.readFileAsString(actual.eventPayloadFile!),
-                await fs.readFileAsString(absPayloadPath)
-            )
+            assert.strictEqual(await fs.readFileText(actual.eventPayloadFile!), await fs.readFileText(absPayloadPath))
             await assertFileText(
                 expected.templatePath,
                 `Resources:
@@ -2698,8 +2695,8 @@ describe('SamDebugConfigurationProvider', async function () {
 
             assertEqualLaunchConfigs(actual, expected)
             assert.strictEqual(
-                await fs.readFileAsString(actual.eventPayloadFile!),
-                await fs.readFileAsString(input.lambda.payload.path)
+                await fs.readFileText(actual.eventPayloadFile!),
+                await fs.readFileText(input.lambda.payload.path)
             )
             await assertFileText(
                 expected.templatePath,

packages/core/src/testE2E/amazonqGumby/transformByQ.test.ts

@@ -52,7 +52,7 @@ describe('transformByQ', async function () {
     })
 
     it('WHEN upload payload with missing sha256 in headers THEN fails to upload', async function () {
-        const buffer = Buffer.from(await fs.readFile(zippedCodePath))
+        const buffer = Buffer.from(await fs.readFileBytes(zippedCodePath))
         const sha256 = getSha256(buffer)
         const response = await codeWhisperer.codeWhispererClient.createUploadUrl({
             contentChecksum: sha256,
@@ -63,7 +63,7 @@ describe('transformByQ', async function () {
             'x-amz-checksum-sha256': '',
             'Content-Type': 'application/zip',
         }
-        const body = await fs.readFileAsString(zippedCodePath)
+        const body = await fs.readFileText(zippedCodePath)
         await assert.rejects(
             () =>
                 request.fetch('PUT', response.uploadUrl, {
@@ -88,7 +88,7 @@ describe('transformByQ', async function () {
     })
 
     it('WHEN createUploadUrl THEN URL uses HTTPS and sets 60 second expiration', async function () {
-        const buffer = Buffer.from(await fs.readFile(zippedCodePath))
+        const buffer = Buffer.from(await fs.readFileBytes(zippedCodePath))
         const sha256 = getSha256(buffer)
         const response = await codeWhisperer.codeWhispererClient.createUploadUrl({
             contentChecksum: sha256,