refactor: move throttle up

Author: Hweinstock

packages/core/src/auth/auth.ts

@@ -21,7 +21,7 @@ import { SsoClient } from './sso/clients'
 import { getLogger } from '../shared/logger'
 import { CredentialsProviderManager } from './providers/credentialsProviderManager'
 import { asString, CredentialsId, CredentialsProvider, fromString } from './providers/credentials'
-import { keyedDebounce, once } from '../shared/utilities/functionUtils'
+import { keyedDebounce, once, throttle } from '../shared/utilities/functionUtils'
 import { CredentialsSettings } from './credentials/utils'
 import {
     extractDataFromSection,
@@ -248,8 +248,8 @@ export class Auth implements AuthService, ConnectionManager {
         this.#onDidChangeActiveConnection.fire(undefined)
     }
 
-    @withTelemetryContext({ name: 'listConnections', class: authClassName })
-    public async listConnections(): Promise<Connection[]> {
+    @withTelemetryContext({ name: 'listConnections', class: authClassName, emit: true })
+    private async listConnectionsDefault(): Promise<Connection[]> {
         await loadIamProfilesIntoStore(this.store, this.iamProfileProvider)
 
         const connections = await Promise.all(
@@ -259,6 +259,8 @@ export class Auth implements AuthService, ConnectionManager {
         return connections
     }
 
+    public listConnections = throttle(() => this.listConnectionsDefault(), 500)
+
     /**
      * Gathers all local profiles plus any AWS accounts/roles associated with SSO ("IAM Identity
      * Center", "IdC") connections.

packages/core/src/auth/providers/credentialsProviderManager.ts

@@ -4,9 +4,8 @@
  */
 
 import { getLogger } from '../../shared/logger'
-import { AwsLoadCredentials, telemetry } from '../../shared/telemetry/telemetry'
+import { telemetry } from '../../shared/telemetry/telemetry'
 import { withTelemetryContext } from '../../shared/telemetry/util'
-import { cancellableDebounce } from '../../shared/utilities/functionUtils'
 import {
     asString,
     CredentialsProvider,
@@ -26,7 +25,7 @@ export class CredentialsProviderManager {
     private readonly providerFactories: CredentialsProviderFactory[] = []
     private readonly providers: CredentialsProvider[] = []
 
-    @withTelemetryContext({ name: 'getAllCredentialsProvider', class: credentialsProviderManagerClassName, emit: true })
+    @withTelemetryContext({ name: 'getAllCredentialsProvider', class: credentialsProviderManagerClassName })
     public async getAllCredentialsProviders(): Promise<CredentialsProvider[]> {
         let providers: CredentialsProvider[] = []
 
@@ -52,7 +51,7 @@ export class CredentialsProviderManager {
                 continue
             }
 
-            void this.emitWithDebounce({
+            telemetry.aws_loadCredentials.emit({
                 credentialSourceId: credentialsProviderToTelemetryType(providerType),
                 value: refreshed.length,
             })
@@ -61,10 +60,7 @@ export class CredentialsProviderManager {
 
         return providers
     }
-    private emitWithDebounce = cancellableDebounce(
-        (m: AwsLoadCredentials) => telemetry.aws_loadCredentials.emit(m),
-        100
-    ).promise
+
     /**
      * Returns a map of `CredentialsProviderId` string-forms to object-forms,
      * from all credential sources. Only available providers are returned.