lint: disallow core/dist/ imports (#4907)

* lint: disallow core/dist/ imports

Problem: Auto-complete sometimes imports from the dist folder of the core lib, if you are working in another subproject.

Solution: lint rule

Author: hayemaxi

.eslintrc.js

@@ -153,13 +153,23 @@ module.exports = {
         'aws-toolkits/no-only-in-tests': 'error',
         'aws-toolkits/no-await-on-vscode-msg': 'error',
 
-        // The following will place an error on the `fs-extra` import since we do not want it to be used for browser compatibility reasons.
-        // "no-restricted-imports": [
-        //     "error",
-        //     {
-        //         "name": "fs-extra",
-        //         "message": "Avoid fs-extra, use FileSystemCommon. Notify the Toolkit team if your required functionality is not available."
-        //     }
-        // ],
+        'no-restricted-imports': [
+            'error',
+            {
+                patterns: [
+                    {
+                        group: ['**/core/dist/*'],
+                        message:
+                            "Avoid importing from the core lib's dist/ folders; please use directly from the core lib defined exports.",
+                    },
+                ],
+            },
+            // The following will place an error on the `fs-extra` import since we do not want it to be used for browser compatibility reasons.
+            // {
+            //     name: 'fs-extra',
+            //     message:
+            //         'Avoid fs-extra, use FileSystemCommon. Notify the Toolkit team if your required functionality is not available.',
+            // },
+        ],
     },
 }