throw error if node is not in map

Author: Hweinstock

packages/core/src/awsService/ec2/explorer/ec2ParentNode.ts

@@ -52,9 +52,18 @@ export class Ec2ParentNode extends AWSTreeNodeBase {
         )
     }
 
+    public getInstanceNode(instanceId: string): Ec2InstanceNode {
+        const childNode = this.ec2InstanceNodes.get(instanceId)
+        if (childNode) {
+            return childNode
+        } else {
+            throw new Error(`Node with id ${instanceId} not found`)
+        }
+    }
+
     private async updatePendingNodes() {
         for (const instanceId of this.pollingSet.values()) {
-            const childNode = this.ec2InstanceNodes.get(instanceId)!
+            const childNode = this.getInstanceNode(instanceId)
             await this.updatePendingNode(childNode)
         }
     }

packages/core/src/test/awsService/ec2/explorer/ec2ParentNode.test.ts

@@ -182,4 +182,23 @@ describe('ec2ParentNode', function () {
         sinon.assert.called(refreshStub)
         statusUpdateStub.restore()
     })
+
+    it('returns the node when in the map', async function () {
+        const instances = [{ Name: 'firstOne', InstanceId: 'node1', LastSeenStatus: 'pending' }]
+
+        getInstanceStub.resolves(mapToInstanceCollection(instances))
+        await testNode.updateChildren()
+        const node = testNode.getInstanceNode('node1')
+        assert.strictEqual(node.InstanceId, instances[0].InstanceId)
+        getInstanceStub.restore()
+    })
+
+    it('throws error when node not in map', async function () {
+        const instances = [{ Name: 'firstOne', InstanceId: 'node1', LastSeenStatus: 'pending' }]
+
+        getInstanceStub.resolves(mapToInstanceCollection(instances))
+        await testNode.updateChildren()
+        assert.throws(() => testNode.getInstanceNode('node2'))
+        getInstanceStub.restore()
+    })
 })