Skip to content

Commit 849006b

Browse files
committed
undo more unnecessary changes
1 parent eb3526a commit 849006b

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

packages/amazonq/test/unit/codewhisperer/tracker/codewhispererTracker.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import assert from 'assert'
77
import * as sinon from 'sinon'
88
import { assertTelemetryCurried } from 'aws-core-vscode/test'
9-
import { CodeWhispererTracker } from 'aws-core-vscode/codewhisperer'
9+
import { AuthUtil, CodeWhispererTracker } from 'aws-core-vscode/codewhisperer'
1010
import { resetCodeWhispererGlobalVariables, createAcceptedSuggestionEntry } from 'aws-core-vscode/test'
1111
import { globals } from 'aws-core-vscode/shared'
1212

@@ -93,8 +93,7 @@ describe('codewhispererTracker', function () {
9393
codewhispererModificationPercentage: 1,
9494
codewhispererCompletionType: 'Line',
9595
codewhispererLanguage: 'java',
96-
// TODO: fix this
97-
// credentialStartUrl: AuthUtil.instance.connection?.startUrl,
96+
credentialStartUrl: AuthUtil.instance.connection?.startUrl,
9897
codewhispererCharactersAccepted: suggestion.originalString.length,
9998
codewhispererCharactersModified: 0,
10099
})

packages/core/src/amazonqFeatureDev/client/featureDev.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ const writeAPIRetryOptions = {
5151

5252
// Create a client for featureDev proxy client based off of aws sdk v2
5353
export async function createFeatureDevProxyClient(options?: Partial<ServiceOptions>): Promise<FeatureDevProxyClient> {
54-
const bearerToken = await AuthUtil.instance.getBearerToken()
54+
const bearerToken = await AuthUtil.instance.getToken()
5555
const cwsprConfig = getCodewhispererConfig()
5656
return (await globals.sdkClientBuilder.createAwsService(
5757
Service,

packages/core/src/codewhisperer/client/codewhisperer.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
import { AWSError, HttpRequest, Service } from 'aws-sdk'
6+
import { AWSError, Credentials, Service } from 'aws-sdk'
77
import globals from '../../shared/extensionGlobals'
88
import * as CodeWhispererClient from './codewhispererclient'
99
import * as CodeWhispererUserClient from './codewhispereruserclient'
@@ -13,8 +13,8 @@ import { hasVendedIamCredentials } from '../../auth/auth'
1313
import { CodeWhispererSettings } from '../util/codewhispererSettings'
1414
import { PromiseResult } from 'aws-sdk/lib/request'
1515
import { AuthUtil } from '../util/authUtil'
16-
import userApiConfig = require('./user-service-2.json')
1716
import apiConfig = require('./service-2.json')
17+
import userApiConfig = require('./user-service-2.json')
1818
import { session } from '../util/codeWhispererSession'
1919
import { getLogger } from '../../shared/logger/logger'
2020
import { getClientId, getOptOutPreference, getOperatingSystem } from '../../shared/telemetry/util'
@@ -84,13 +84,14 @@ export type Imports = CodeWhispererUserClient.Imports
8484
export class DefaultCodeWhispererClient {
8585
private async createSdkClient(): Promise<CodeWhispererClient> {
8686
const isOptedOut = CodeWhispererSettings.instance.isOptoutEnabled()
87+
const credential = await AuthUtil.instance.getIamCredential()
8788
const cwsprConfig = getCodewhispererConfig()
8889
return (await globals.sdkClientBuilder.createAwsService(
8990
Service,
9091
{
9192
apiConfig: apiConfig,
9293
region: cwsprConfig.region,
93-
credentials: undefined,
94+
credentials: new Credentials({ accessKeyId: credential.accessKeyId, secretAccessKey: credential.secretAccessKey }),
9495
endpoint: cwsprConfig.endpoint,
9596
onRequestSetup: [
9697
(req) => {
@@ -108,9 +109,9 @@ export class DefaultCodeWhispererClient {
108109
resp.error?.code === 'AccessDeniedException' &&
109110
resp.error.message.match(/expired/i)
110111
) {
111-
// AuthUtil.instance.reauthenticate().catch((e) => {
112-
// getLogger().error('reauthenticate failed: %s', (e as Error).message)
113-
// })
112+
AuthUtil.instance.reauthenticate()?.catch((e) => {
113+
getLogger().error('reauthenticate failed: %s', (e as Error).message)
114+
})
114115
resp.error.retryable = true
115116
}
116117
})
@@ -125,7 +126,7 @@ export class DefaultCodeWhispererClient {
125126
async createUserSdkClient(maxRetries?: number): Promise<CodeWhispererUserClient> {
126127
const isOptedOut = CodeWhispererSettings.instance.isOptoutEnabled()
127128
session.setFetchCredentialStart()
128-
const credential = await AuthUtil.instance.getBearerToken()
129+
const bearerToken = await AuthUtil.instance.getToken()
129130

130131
session.setSdkApiCallStart()
131132
const cwsprConfig = getCodewhispererConfig()
@@ -137,9 +138,9 @@ export class DefaultCodeWhispererClient {
137138
endpoint: cwsprConfig.endpoint,
138139
maxRetries: maxRetries,
139140
onRequestSetup: [
140-
(req: any) => {
141-
req.on('build', ({ httpRequest }: { httpRequest: HttpRequest }) => {
142-
httpRequest.headers['Authorization'] = `Bearer ${credential}`
141+
(req) => {
142+
req.on('build', ({ httpRequest }) => {
143+
httpRequest.headers['Authorization'] = `Bearer ${bearerToken}`
143144
})
144145
if (req.operation === 'generateCompletions') {
145146
req.on('build', () => {

packages/core/src/codewhisperer/region/regionProfileManager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,12 +428,12 @@ export class RegionProfileManager {
428428
async _createQClient(region: string, endpoint: string): Promise<CodeWhispererUserClient> {
429429
let authConfig: ServiceOptions = {}
430430
if (this.authProvider.isSsoSession()) {
431-
const credential = await this.authProvider.getBearerToken()
431+
const token = await this.authProvider.getToken()
432432
authConfig = {
433433
onRequestSetup: [
434434
(req: any) => {
435435
req.on('build', ({ httpRequest }: { httpRequest: HttpRequest }) => {
436-
httpRequest.headers['Authorization'] = `Bearer ${credential}`
436+
httpRequest.headers['Authorization'] = `Bearer ${token}`
437437
})
438438
},
439439
],

packages/core/src/codewhisperer/util/authUtil.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export interface IAuthProvider {
6161
isIdcConnection(): boolean
6262
isSsoSession(): boolean
6363
isIamSession(): boolean
64-
getBearerToken(): Promise<string>
64+
getToken(): Promise<string>
6565
getIamCredential(): Promise<IamCredentials>
6666
readonly profileName: string
6767
readonly connection?: { startUrl?: string; region?: string; accessKey?: string; secretKey?: string }
@@ -202,7 +202,7 @@ export class AuthUtil implements IAuthProvider {
202202
return response
203203
}
204204

205-
async getBearerToken() {
205+
async getToken() {
206206
if (this.isSsoSession()) {
207207
return (await (this.session as SsoLogin).getCredential()).credential
208208
} else {

packages/core/src/shared/clients/codewhispererChatClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { getUserAgent } from '../telemetry/util'
1010

1111
// Create a client for featureDev streaming based off of aws sdk v3
1212
export async function createCodeWhispererChatStreamingClient(): Promise<CodeWhispererStreaming> {
13-
const bearerToken = await AuthUtil.instance.getBearerToken()
13+
const bearerToken = await AuthUtil.instance.getToken()
1414
const cwsprConfig = getCodewhispererConfig()
1515
const streamingClient = new CodeWhispererStreaming({
1616
region: cwsprConfig.region,

0 commit comments

Comments
 (0)