change rule name

Author: Hweinstock

.eslintrc.js

@@ -163,7 +163,7 @@ module.exports = {
         'aws-toolkits/no-string-exec-for-child-process': 'error',
         'aws-toolkits/no-console-log': 'error',
         'aws-toolkits/no-json-stringify-in-log': 'error',
-        'aws-toolkits/no-string-sub-mismatch': 'error',
+        'aws-toolkits/no-printf-mismatch': 'error',
         'no-restricted-imports': [
             'error',
             {

packages/core/src/shared/filesystemUtilities.ts

@@ -245,7 +245,7 @@ export async function setDefaultDownloadPath(downloadPath: string) {
             await globals.globalState.update('aws.downloadPath', path.dirname(downloadPath))
         }
     } catch (err) {
-        getLogger().error('Error while setting "aws.downloadPath" \n %O', err as Error)
+        getLogger().error('Error while setting "aws.downloadPath": %O', err as Error)
     }
 }
 

plugins/eslint-plugin-aws-toolkits/index.ts

@@ -10,7 +10,7 @@ import NoOnlyInTests from './lib/rules/no-only-in-tests'
 import NoStringExecForChildProcess from './lib/rules/no-string-exec-for-child-process'
 import NoConsoleLog from './lib/rules/no-console-log'
 import noJsonStringifyInLog from './lib/rules/no-json-stringify-in-log'
-import noStringSubMismatch from './lib/rules/no-string-sub-mismatch'
+import noPrintfMismatch from './lib/rules/no-printf-mismatch'
 
 const rules = {
     'no-await-on-vscode-msg': NoAwaitOnVscodeMsg,
@@ -20,7 +20,7 @@ const rules = {
     'no-string-exec-for-child-process': NoStringExecForChildProcess,
     'no-console-log': NoConsoleLog,
     'no-json-stringify-in-log': noJsonStringifyInLog,
-    'no-string-sub-mismatch': noStringSubMismatch,
+    'no-printf-mismatch': noPrintfMismatch,
 }
 
 export { rules }

plugins/eslint-plugin-aws-toolkits/lib/rules/no-string-sub-mismatch.ts renamed to plugins/eslint-plugin-aws-toolkits/lib/rules/no-printf-mismatch.ts

@@ -18,7 +18,7 @@ function countSubTokens(literalNode: TSESTree.StringLiteral) {
  * Allows us to avoid copy pasting message into test file.
  */
 export function formErrorMsg(substitutionTokens: string | number, numArgs: string | number): string {
-    return `String substitution has ${substitutionTokens} format specifiers, but ${numArgs} arguments.`
+    return `printf-style (console.log) call has ${substitutionTokens} format specifiers, but ${numArgs} arguments.`
 }
 
 export default ESLintUtils.RuleCreator.withoutDocs({

plugins/eslint-plugin-aws-toolkits/test/rules/no-string-sub-mismatch.test.ts

@@ -4,7 +4,7 @@
  */
 
 import { rules } from '../../index'
-import { formErrorMsg } from '../../lib/rules/no-string-sub-mismatch'
+import { formErrorMsg } from '../../lib/rules/no-printf-mismatch'
 import { getRuleTester } from '../testUtil'
 
 getRuleTester().run('no-string-sub-mismatch', rules['no-string-sub-mismatch'], {