Skip to content

Commit 8a5b8d9

Browse files
authored
test(credentials): do not modify developer $HOME #5791
## Problem https://github.com/aws/aws-toolkit-vscode/blob/0164d4145e58ae036ddf3815455ea12a159d491d/packages/core/src/test/shared/credentials/userCredentialsUtils.test.ts#L38-L39 This test is deleting my actual aws config file. ## Solution Update the environment variable to point to a fake location before test Then recover them after test
1 parent 0164d41 commit 8a5b8d9

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

packages/core/src/test/shared/credentials/userCredentialsUtils.test.ts

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,31 +18,20 @@ import {
1818
import { UserCredentialsUtils } from '../../../shared/credentials/userCredentialsUtils'
1919
import { EnvironmentVariables } from '../../../shared/environmentVariables'
2020
import { makeTemporaryToolkitFolder } from '../../../shared/filesystemUtilities'
21-
import { getConfigFilename, getCredentialsFilename } from '../../../auth/credentials/sharedCredentialsFile'
2221
import { fs } from '../../../shared'
2322

2423
describe('UserCredentialsUtils', function () {
2524
let tempFolder: string
26-
let defaultConfigFileName: string
27-
let defaultCredentialsFilename: string
2825

29-
before(async function () {
30-
defaultConfigFileName = getConfigFilename()
31-
defaultCredentialsFilename = getCredentialsFilename()
26+
beforeEach(async function () {
3227
// Make a temp folder for all these tests
3328
// Stick some temp credentials files in there to load from
3429
tempFolder = await makeTemporaryToolkitFolder()
3530
})
3631

3732
afterEach(async function () {
38-
await fs.delete(defaultConfigFileName, { recursive: true })
39-
await fs.delete(defaultCredentialsFilename, { recursive: true })
40-
41-
sinon.restore()
42-
})
43-
44-
after(async function () {
4533
await fs.delete(tempFolder, { recursive: true })
34+
sinon.restore()
4635
})
4736

4837
describe('findExistingCredentialsFilenames', function () {
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Bug Fix",
3+
"description": "Fix userCredentialsUtils.test.ts so it won't remove the actual aws config"
4+
}

0 commit comments

Comments
 (0)