Skip to content

Commit 8a85bf3

Browse files
committed
ci: only run "lint" in "insiders" job
Problem: The release pipeline is blocked on the lint task because of an environment issue (there is not actually a git secret in the source code, this test already passed CI). 1) git-secrets sanity check it finds secrets: AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: at Context.<anonymous> (src/testLint/gitSecrets.test.ts:125:16) Solution: Only run lint in "insiders" job. That allows the release pipeline to proceed. Followup to: 6057ef4
1 parent dfb267d commit 8a85bf3

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

buildspec/linuxTests.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,11 @@ phases:
4545
commands:
4646
- export HOME=/home/codebuild-user
4747
# TODO: run lint as a separate codebuild job.
48-
- npm run testCompile
49-
- npm run lint
48+
- |
49+
if [ "$VSCODE_TEST_VERSION" = 'insiders' ] ; then
50+
npm run testCompile
51+
npm run lint
52+
fi
5053
- xvfb-run npm test --silent
5154
- VCS_COMMIT_ID="${CODEBUILD_RESOLVED_SOURCE_VERSION}"
5255
- CI_BUILD_URL=$(echo $CODEBUILD_BUILD_URL | sed 's/#/%23/g') # Encode `#` in the URL because otherwise the url is clipped in the Codecov.io site

0 commit comments

Comments
 (0)