Skip to content

Commit 8b72fa2

Browse files
committed
refactor: cleanup
1 parent 46b1189 commit 8b72fa2

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

packages/core/src/awsService/apprunner/explorer/apprunnerNode.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export class AppRunnerNode extends AWSTreeNodeBase {
2424

2525
public constructor(
2626
public override readonly regionCode: string,
27-
public client: AppRunnerClient
27+
public readonly client: AppRunnerClient
2828
) {
2929
super('App Runner', vscode.TreeItemCollapsibleState.Collapsed)
3030
this.contextValue = 'awsAppRunnerNode'

packages/core/src/awsService/apprunner/explorer/apprunnerServiceNode.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import * as nls from 'vscode-nls'
1616
import { getLogger } from '../../../shared/logger/logger'
1717
import { getIcon } from '../../../shared/icons'
1818
import { DefaultCloudWatchLogsClient } from '../../../shared/clients/cloudWatchLogsClient'
19-
import { OperationSummary, Service, ServiceSummary, UpdateServiceRequest } from '@aws-sdk/client-apprunner'
19+
import { OperationSummary, UpdateServiceRequest } from '@aws-sdk/client-apprunner'
2020
const localize = nls.loadMessageBundle()
2121

2222
const contextBase = 'awsAppRunnerServiceNode'
@@ -135,7 +135,7 @@ export class AppRunnerServiceNode extends CloudWatchLogsBase implements AWSResou
135135
})
136136
}
137137

138-
private updateInfo(info: ServiceSummary | Service): void {
138+
private updateInfo(info: AppRunnerServiceSummary): void {
139139
if (info.Status === 'OPERATION_IN_PROGRESS' && this.currentOperation.Type === undefined) {
140140
// Asynchronous since it is not currently possible for race-conditions to occur with updating operations
141141
void this.updateOperation()

packages/core/src/awsService/apprunner/wizards/codeRepositoryWizard.ts

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import {
2424
QuickPickPrompter,
2525
} from '../../../shared/ui/pickerPrompter'
2626
import { createInputBox, InputBoxPrompter } from '../../../shared/ui/inputPrompter'
27-
import { apprunnerConnectionHelpUrl, apprunnerRuntimeHelpUrl } from '../../../shared/constants'
27+
import { apprunnerConfigHelpUrl, apprunnerConnectionHelpUrl, apprunnerRuntimeHelpUrl } from '../../../shared/constants'
2828
import { Wizard, WIZARD_BACK } from '../../../shared/wizards/wizard'
2929
import { openUrl } from '../../../shared/utilities/vsCodeUtils'
3030
import { getAppRunnerCreateServiceDocUrl } from '../../../shared/extensionUtilities'
@@ -196,10 +196,17 @@ function createSourcePrompter(): QuickPickPrompter<ConfigurationSource> {
196196
)
197197
const apiLabel = localize('AWS.apprunner.createService.configSource.apiLabel', 'Configure all settings here')
198198
const repoLabel = localize('AWS.apprunner.createService.configSource.repoLabel', 'Use configuration file')
199-
const apiItem = { label: apiLabel, data: ConfigurationSource.API }
200-
const repoItem = { label: repoLabel, data: ConfigurationSource.REPOSITORY, detail: configDetail }
199+
const apiItem: DataQuickPickItem<ConfigurationSource> = { label: apiLabel, data: ConfigurationSource.API }
200+
const repoItem: DataQuickPickItem<ConfigurationSource> = {
201+
label: repoLabel,
202+
data: ConfigurationSource.REPOSITORY,
203+
detail: configDetail,
204+
}
201205

202-
return createQuickPick([apiItem, repoItem])
206+
return createQuickPick([apiItem, repoItem], {
207+
title: localize('AWS.apprunner.createService.configSource.title', 'Choose configuration source'),
208+
buttons: createCommonButtons(apprunnerConfigHelpUrl),
209+
})
203210
}
204211

205212
function createCodeRepositorySubForm(git: GitExtension): WizardForm<AppRunnerCodeRepository> {

0 commit comments

Comments
 (0)