Skip to content

Commit 8ff69bb

Browse files
authored
fix(ci): remove deprecated Python configs #3988
Problem: 1) SAM Integration Tests "before all" hook in "SAM Integration Tests": CodeExpectedError: Unable to write to Workspace Settings because python.linting.pylintEnabled is not a registered configuration. Solution: Remove setting that was broken upstream. integ logs from last successful integ CI on master is comparable to PR (both ~27k lines).
1 parent 9ed5632 commit 8ff69bb

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

src/testInteg/integrationTestsUtilities.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,6 @@ export async function configureAwsToolkitExtension(): Promise<void> {
3434
await configAws.update('samcli.enableCodeLenses', true, false)
3535
}
3636

37-
export async function configurePythonExtension(): Promise<void> {
38-
const configPy = vscode.workspace.getConfiguration('python')
39-
// Disable linting to silence some of the Python extension's log spam
40-
await configPy.update('linting.pylintEnabled', false, false)
41-
await configPy.update('linting.enabled', false, false)
42-
}
43-
4437
// Installs tools that the Go extension wants (it complains a lot if we don't)
4538
// Had to dig around for the commands used by the Go extension.
4639
// Ref: https://github.com/golang/vscode-go/blob/0058bd16ba31394f98aa3396056998e4808998a7/src/goTools.ts#L211

src/testInteg/sam.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,6 @@ describe('SAM Integration Tests', async function () {
380380

381381
await activateExtensions()
382382
await testUtils.configureAwsToolkitExtension()
383-
await testUtils.configurePythonExtension()
384383
// await testUtils.configureGoExtension()
385384

386385
testSuiteRoot = await mkdtemp(path.join(projectFolder, 'inttest'))

0 commit comments

Comments
 (0)