telemetry(amazonq): drop collectFiles instrumentation #5725

## Problem
- Follow up on the previous remove trackPerformance PR, we no longer
need collectFiles telemetry since the data isn't reliable in the
extension host
- integ tests are failing because of this

## Solution
- Remove the instrumentation

Author: jpinkney-aws

packages/core/src/shared/telemetry/vscodeTelemetry.json

@@ -1157,22 +1157,6 @@
             "name": "function_call",
             "description": "Represents a function call. In most cases this should wrap code with a run(), then you can add context.",
             "metadata": [
-                {
-                    "type": "userCpuUsage",
-                    "required": false
-                },
-                {
-                    "type": "systemCpuUsage",
-                    "required": false
-                },
-                {
-                    "type": "architecture",
-                    "required": false
-                },
-                {
-                    "type": "heapTotal",
-                    "required": false
-                },
                 {
                     "type": "functionName",
                     "required": true

packages/core/src/shared/utilities/workspaceUtils.ts

@@ -17,7 +17,6 @@ import { sanitizeFilename } from './textUtilities'
 import { GitIgnoreAcceptor } from '@gerhobbelt/gitignore-parser'
 import * as parser from '@gerhobbelt/gitignore-parser'
 import fs from '../fs/fs'
-import { telemetry } from '../telemetry'
 
 type GitIgnoreRelativeAcceptor = {
     folderPath: string
@@ -323,80 +322,70 @@ export async function collectFiles(
         zipFilePath: string
     }[]
 > {
-    return telemetry.function_call.run(
-        async (span) => {
-            const storage: Awaited<ReturnType<typeof collectFiles>> = []
-
-            const workspaceFoldersMapping = getWorkspaceFoldersByPrefixes(workspaceFolders)
-            const workspaceToPrefix = new Map<vscode.WorkspaceFolder, string>(
-                workspaceFoldersMapping === undefined
-                    ? [[workspaceFolders[0], '']]
-                    : Object.entries(workspaceFoldersMapping).map((value) => [value[1], value[0]])
-            )
-            const prefixWithFolderPrefix = (folder: vscode.WorkspaceFolder, path: string) => {
-                const prefix = workspaceToPrefix.get(folder)
-                /**
-                 * collects all files that are marked as source
-                 * @param sourcePaths the paths where collection starts
-                 * @param workspaceFolders the current workspace folders opened
-                 * @param respectGitIgnore whether to respect gitignore file
-                 * @returns all matched files
-                 */
-                if (prefix === undefined) {
-                    throw new ToolkitError(`Failed to find prefix for workspace folder ${folder.name}`)
-                }
-                return prefix === '' ? path : `${prefix}/${path}`
-            }
+    const storage: Awaited<ReturnType<typeof collectFiles>> = []
 
-            let totalSizeBytes = 0
-            for (const rootPath of sourcePaths) {
-                const allFiles = await vscode.workspace.findFiles(
-                    new vscode.RelativePattern(rootPath, '**'),
-                    getExcludePattern()
-                )
+    const workspaceFoldersMapping = getWorkspaceFoldersByPrefixes(workspaceFolders)
+    const workspaceToPrefix = new Map<vscode.WorkspaceFolder, string>(
+        workspaceFoldersMapping === undefined
+            ? [[workspaceFolders[0], '']]
+            : Object.entries(workspaceFoldersMapping).map((value) => [value[1], value[0]])
+    )
+    const prefixWithFolderPrefix = (folder: vscode.WorkspaceFolder, path: string) => {
+        const prefix = workspaceToPrefix.get(folder)
+        /**
+         * collects all files that are marked as source
+         * @param sourcePaths the paths where collection starts
+         * @param workspaceFolders the current workspace folders opened
+         * @param respectGitIgnore whether to respect gitignore file
+         * @returns all matched files
+         */
+        if (prefix === undefined) {
+            throw new ToolkitError(`Failed to find prefix for workspace folder ${folder.name}`)
+        }
+        return prefix === '' ? path : `${prefix}/${path}`
+    }
 
-                const files = respectGitIgnore ? await filterOutGitignoredFiles(rootPath, allFiles) : allFiles
+    let totalSizeBytes = 0
+    for (const rootPath of sourcePaths) {
+        const allFiles = await vscode.workspace.findFiles(
+            new vscode.RelativePattern(rootPath, '**'),
+            getExcludePattern()
+        )
 
-                for (const file of files) {
-                    const relativePath = getWorkspaceRelativePath(file.fsPath, { workspaceFolders })
-                    if (!relativePath) {
-                        continue
-                    }
+        const files = respectGitIgnore ? await filterOutGitignoredFiles(rootPath, allFiles) : allFiles
 
-                    const fileStat = await fs.stat(file)
-                    if (totalSizeBytes + fileStat.size > maxSize) {
-                        throw new ToolkitError(
-                            'The project you have selected for source code is too large to use as context. Please select a different folder to use',
-                            { code: 'ContentLengthError' }
-                        )
-                    }
+        for (const file of files) {
+            const relativePath = getWorkspaceRelativePath(file.fsPath, { workspaceFolders })
+            if (!relativePath) {
+                continue
+            }
 
-                    const fileContent = await readFile(file)
+            const fileStat = await fs.stat(file)
+            if (totalSizeBytes + fileStat.size > maxSize) {
+                throw new ToolkitError(
+                    'The project you have selected for source code is too large to use as context. Please select a different folder to use',
+                    { code: 'ContentLengthError' }
+                )
+            }
 
-                    if (fileContent === undefined) {
-                        continue
-                    }
+            const fileContent = await readFile(file)
 
-                    // Now that we've read the file, increase our usage
-                    totalSizeBytes += fileStat.size
-                    storage.push({
-                        workspaceFolder: relativePath.workspaceFolder,
-                        relativeFilePath: relativePath.relativePath,
-                        fileUri: file,
-                        fileContent: fileContent,
-                        zipFilePath: prefixWithFolderPrefix(relativePath.workspaceFolder, relativePath.relativePath),
-                    })
-                }
+            if (fileContent === undefined) {
+                continue
             }
-            return storage
-        },
-        {
-            emit: true,
-            functionId: {
-                name: 'collectFiles',
-            },
+
+            // Now that we've read the file, increase our usage
+            totalSizeBytes += fileStat.size
+            storage.push({
+                workspaceFolder: relativePath.workspaceFolder,
+                relativeFilePath: relativePath.relativePath,
+                fileUri: file,
+                fileContent: fileContent,
+                zipFilePath: prefixWithFolderPrefix(relativePath.workspaceFolder, relativePath.relativePath),
+            })
         }
-    )
+    }
+    return storage
 }
 
 const readFile = async (file: vscode.Uri) => {

packages/core/src/testInteg/shared/utilities/workspaceUtils.test.ts

@@ -16,7 +16,7 @@ import {
 import { getTestWorkspaceFolder } from '../../integrationTestsUtilities'
 import globals from '../../../shared/extensionGlobals'
 import { CodelensRootRegistry } from '../../../shared/fs/codelensRootRegistry'
-import { assertTelemetry, createTestWorkspace, createTestWorkspaceFolder, toFile } from '../../../test/testUtil'
+import { createTestWorkspace, createTestWorkspaceFolder, toFile } from '../../../test/testUtil'
 import sinon from 'sinon'
 import { performanceTest } from '../../../shared/performance/performance'
 import { randomUUID } from '../../../shared/crypto'
@@ -298,10 +298,6 @@ describe('collectFiles', function () {
             ] satisfies typeof result,
             result
         )
-
-        assertTelemetry('function_call', {
-            functionName: 'collectFiles',
-        })
     })
 
     it('does not return license files', async function () {