fix(telemetry): metrics emitted without the result property #4295

justinmk3 · web-flow · commit 976fb893b249 · 2024-01-17T16:33:27.000-08:00
2024-01-17 12:50:54 [WARN]: Metric Event did not pass validation:
    Metric `aws_expandExplorerNode` was emitted without the `result` property.
diff --git a/src/awsexplorer/activation.ts b/src/awsexplorer/activation.ts
@@ -60,7 +60,7 @@ export async function activate(args: {
             })
         }
         if (element.element.serviceId) {
-            telemetry.aws_expandExplorerNode.emit({ serviceType: element.element.serviceId })
+            telemetry.aws_expandExplorerNode.emit({ serviceType: element.element.serviceId, result: 'Succeeded' })
         }
     })
     globals.context.subscriptions.push(view)

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ export async function activate(args: {`
`60`	`60`	`})`
`61`	`61`	`}`
`62`	`62`	`if (element.element.serviceId) {`
`63`		`- telemetry.aws_expandExplorerNode.emit({ serviceType: element.element.serviceId })`
	`63`	`+ telemetry.aws_expandExplorerNode.emit({ serviceType: element.element.serviceId, result: 'Succeeded' })`
`64`	`64`	`}`
`65`	`65`	`})`
`66`	`66`	`globals.context.subscriptions.push(view)`