make options an optional param

Hweinstock · Hweinstock · commit 9d14980e9f92 · 2024-11-12T15:07:29.000-05:00
diff --git a/packages/core/src/shared/vscode/env.ts b/packages/core/src/shared/vscode/env.ts
@@ -67,9 +67,9 @@ export { extensionVersion }
  *
  * @param throwWhen Throw if minimum vscode is equal or later than this version.
  */
-export function isMinVscode(options: { throwWhen: string }): boolean {
+export function isMinVscode(options?: { throwWhen: string }): boolean {
     const minVscode = getMinVscodeVersion()
-    if (options.throwWhen && semver.gte(minVscode, options.throwWhen)) {
+    if (options?.throwWhen && semver.gte(minVscode, options.throwWhen)) {
         throw Error(`Min vscode ${minVscode} >= ${options.throwWhen}. Delete or update the code that called this.`)
     }
     return vscode.version.startsWith(getMinVscodeVersion())

Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,9 @@ export { extensionVersion }`
`67`	`67`	`*`
`68`	`68`	`* @param throwWhen Throw if minimum vscode is equal or later than this version.`
`69`	`69`	`*/`
`70`		`-export function isMinVscode(options: { throwWhen: string }): boolean {`
	`70`	`+export function isMinVscode(options?: { throwWhen: string }): boolean {`
`71`	`71`	`const minVscode = getMinVscodeVersion()`
`72`		`- if (options.throwWhen && semver.gte(minVscode, options.throwWhen)) {`
	`72`	`+ if (options?.throwWhen && semver.gte(minVscode, options.throwWhen)) {`
`73`	`73`	throw Error(`Min vscode ${minVscode} >= ${options.throwWhen}. Delete or update the code that called this.`)
`74`	`74`	`}`
`75`	`75`	`return vscode.version.startsWith(getMinVscodeVersion())`