fix(codewhisperer): do not clear recommendation if visible #3164

zixlin7 · web-flow · commit 9dd8a8831a52 · 2023-03-01T16:55:17.000-08:00
diff --git a/src/codewhisperer/service/inlineCompletionService.ts b/src/codewhisperer/service/inlineCompletionService.ts
@@ -354,7 +354,7 @@ export class InlineCompletionService {
         config: ConfigurationEntry,
         autoTriggerType?: CodewhispererAutomatedTriggerType
     ) {
-        if (vsCodeState.isCodeWhispererEditing || this._isPaginationRunning) {
+        if (vsCodeState.isCodeWhispererEditing || this._isPaginationRunning || this.isSuggestionVisible()) {
             return
         }
         await this.clearInlineCompletionStates(editor)

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ export class InlineCompletionService {`
`354`	`354`	`config: ConfigurationEntry,`
`355`	`355`	`autoTriggerType?: CodewhispererAutomatedTriggerType`
`356`	`356`	`) {`
`357`		`- if (vsCodeState.isCodeWhispererEditing \|\| this._isPaginationRunning) {`
	`357`	`+ if (vsCodeState.isCodeWhispererEditing \|\| this._isPaginationRunning \|\| this.isSuggestionVisible()) {`
`358`	`358`	`return`
`359`	`359`	`}`
`360`	`360`	`await this.clearInlineCompletionStates(editor)`