Skip to content

Commit a0e4713

Browse files
committed
add test cases for remaining cases
1 parent 104a85f commit a0e4713

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ module.exports = {
178178
'aws-toolkits/no-console-log': 'error',
179179
'aws-toolkits/no-json-stringify-in-log': 'error',
180180
'aws-toolkits/no-printf-mismatch': 'error',
181-
'aws-toolkits/no-inline-async-foreach': 'error',
181+
'aws-toolkits/no-async-in-foreach': 'error',
182182
'no-restricted-imports': [
183183
'error',
184184
{

plugins/eslint-plugin-aws-toolkits/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import NoStringExecForChildProcess from './lib/rules/no-string-exec-for-child-pr
1111
import NoConsoleLog from './lib/rules/no-console-log'
1212
import noJsonStringifyInLog from './lib/rules/no-json-stringify-in-log'
1313
import noPrintfMismatch from './lib/rules/no-printf-mismatch'
14-
import noInlineAsyncForEach from './lib/rules/no-inline-async-foreach'
14+
import noAsyncInForEach from './lib/rules/no-async-in-foreach'
1515

1616
const rules = {
1717
'no-await-on-vscode-msg': NoAwaitOnVscodeMsg,
@@ -22,7 +22,7 @@ const rules = {
2222
'no-console-log': NoConsoleLog,
2323
'no-json-stringify-in-log': noJsonStringifyInLog,
2424
'no-printf-mismatch': noPrintfMismatch,
25-
'no-inline-async-foreach': noInlineAsyncForEach,
25+
'no-async-in-foreach': noAsyncInForEach,
2626
}
2727

2828
export { rules }

plugins/eslint-plugin-aws-toolkits/test/rules/no-inline-async-foreach.test.ts renamed to plugins/eslint-plugin-aws-toolkits/test/rules/no-async-in-foreach.test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
*/
55

66
import { rules } from '../../index'
7-
import { errMsg } from '../../lib/rules/no-inline-async-foreach'
7+
import { errMsg } from '../../lib/rules/no-async-in-foreach'
88
import { getRuleTester } from '../testUtil'
99

10-
getRuleTester().run('no-inline-async-foreach', rules['no-inline-async-foreach'], {
10+
getRuleTester().run('no-async-in-foreach', rules['no-async-in-foreach'], {
1111
valid: [
1212
'list.forEach((a) => a * a)',
1313
'list.forEach(asyncFunctionOrNot)',
@@ -35,5 +35,9 @@ getRuleTester().run('no-inline-async-foreach', rules['no-inline-async-foreach'],
3535
code: 'function f() { \n return new (class c { \n public async f2() {} \n })().f2 \n } \n list.forEach(f())',
3636
errors: [errMsg],
3737
},
38+
{
39+
code: 'function f() { \n return function f2() { \n return function f3() { \n return function f4() { \n return function f5() { \n return async function f6() { \n \n } \n } \n } \n } \n } \n } \n list.forEach(f()()()()())',
40+
errors: [errMsg],
41+
},
3842
],
3943
})

0 commit comments

Comments
 (0)