Skip to content

Commit a12730e

Browse files
committed
factor out shared logic into utility function
1 parent af2bffb commit a12730e

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

packages/core/src/test/applicationcomposer/messageHandlers/generateResourceHandler.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@ import sinon from 'sinon'
88
import { createTemplate, createWebviewContext } from '../utils'
99
import { generateResourceHandler } from '../../../applicationcomposer/messageHandlers/generateResourceHandler'
1010
import { Command, MessageType } from '../../../applicationcomposer/types'
11-
import * as env from '../../../shared/vscode/env'
11+
import { disableIfVscodeBelow } from '../../testUtil'
1212

1313
describe('generateResourceHandler', function () {
1414
it('amazon q is not installed', async function () {
15-
if (env.isMinVscode('1.89.0')) {
16-
this.skip()
17-
}
15+
disableIfVscodeBelow(this, '1.89.0')
1816
const panel = await createTemplate()
1917
const postMessageSpy = sinon.spy(panel.webview, 'postMessage')
2018
const context = await createWebviewContext({

packages/core/src/test/applicationcomposer/messageHandlers/initMessageHandler.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@ import assert from 'assert'
77
import sinon from 'sinon'
88
import { initMessageHandler } from '../../../applicationcomposer/messageHandlers/initMessageHandler'
99
import { createTemplate, createWebviewContext } from '../utils'
10-
import { env } from '../../../shared'
10+
import { disableIfVscodeBelow } from '../../testUtil'
1111

1212
describe('initMessageHandler', function () {
1313
it('not connected to codewhisperer', async function () {
14-
if (env.isMinVscode('1.89.0')) {
15-
this.skip()
16-
}
14+
disableIfVscodeBelow(this, '1.89.0')
1715
const panel = await createTemplate()
1816
const postMessageSpy = sinon.spy(panel.webview, 'postMessage')
1917
const context = await createWebviewContext({

packages/core/src/test/testUtil.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import { mkdirSync, existsSync } from 'fs' // eslint-disable-line no-restricted-
1919
import { randomBytes } from 'crypto'
2020
import request from '../shared/request'
2121
import { stub } from 'sinon'
22+
import { isMinVscode } from '../shared/vscode/env'
2223

2324
const testTempDirs: string[] = []
2425

@@ -634,3 +635,9 @@ export function getFetchStubWithResponse(response: Partial<Response>) {
634635
export function copyEnv(): NodeJS.ProcessEnv {
635636
return { ...process.env }
636637
}
638+
639+
export function disableIfVscodeBelow(context: Mocha.Context, version: string) {
640+
if (isMinVscode(version)) {
641+
context.skip()
642+
}
643+
}

0 commit comments

Comments
 (0)